Summary

Fix minimum height of comment reply editors.

Review Request #13054 — Created May 18, 2023 and submitted May 24, 2023, 10:13 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In the update to the review reply editors to switch to
InlineEditorView, I read the existing code a little bit wrong, and
mistakenly overrode the minimum height default to be zero. This change
removes that override, so that the default height for reply editors is
the default editor minimum (70px).

Testing Done

Opened editors for replies to comments and review headers and saw the
correct minimum editor height.

Commits

Summary	ID
Fix minimum height of comment reply editors. In the update to the review reply editors to switch to `InlineEditorView`, I read the existing code a little bit wrong, and mistakenly overrode the minimum height default to be zero. This change removes that override, so that the default height for reply editors is the default editor minimum (70px). Testing Done: Opened editors for replies to comments and review headers and saw the correct minimum editor height.	3956d3c053add2daa26165dfd2da8987b1b120ef

Summary

Fix minimum height of comment reply editors.

In the update to the review reply editors to switch to `InlineEditorView`, I read the existing code a little bit wrong, and mistakenly overrode the minimum height default to be zero. This change removes that override, so that the default height for reply editors is the default editor minimum (70px). Testing Done: Opened editors for replies to comments and review headers and saw the correct minimum editor height.

3956d3c053add2daa26165dfd2da8987b1b120ef

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed