Add stamping and fix configuration for the Perforce trigger script.

 






 

 


  Review Request #13046
  —
  Created May 15, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  RBTools
 









 
 

  release-4.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
The Perforce trigger script can now stamp changesets with the review

request URL when the change is approved and submitted. This will only be

stamped if not already stamped.


There are also fixes for configuring the API user/token used for

communicating with Review Board.

 








  


 
 

  
Tested all combinations of options locally.


Verified the fixes and improvements with a customer.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add stamping and fix configuration for the Perforce trigger script.
     
The Perforce trigger script can now stamp changesets with the review
request URL when the change is approved and submitted. This will only be
stamped if not already stamped.

There are also fixes for configuring the API user/token used for
communicating with Review Board.

    

   
  		
  a1a034c063096f11e5721427f20a7cadb351e061
  Christian Hammond
 


 
  
 
 
  
   
    

     Add stamping and fix configuration for the Perforce trigger script.
     
The Perforce trigger script can now stamp changesets with the review
request URL when the change is approved and submitted. This will only be
stamped if not already stamped.

There are also fixes for configuring the API user/token used for
communicating with Review Board.

    

   
  		
  3182a44d39b04d7a4a037604e170b4039b6c73b9
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      contrib/tools/p4-trigger-script
     
    

   
  

 










     

    

   

  

  

   
   Loading...