flake8
passed.
JSHint
passed.
Add stamping and fix configuration for the Perforce trigger script.
Review Request #13046 — Created May 15, 2023 and submitted
| Information | |
|---|---|
| chipx86 | |
| RBTools | |
| release-4.x | |
| Reviewers | |
| rbtools | |
The Perforce trigger script can now stamp changesets with the review
request URL when the change is approved and submitted. This will only be
stamped if not already stamped.There are also fixes for configuring the API user/token used for
communicating with Review Board.
Tested all combinations of options locally.
Verified the fixes and improvements with a customer.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Can we put a blank line in between here? This kind of looks like the comment about the ID applies … |
 david
|
-
-
contrib/tools/p4-trigger-script (Diff revision 1) Can we put a blank line in between here? This kind of looks like the comment about the ID applies to the STAMP_CHANGES block.
Change Summary:
Expanded upon a comment in order to make it pertinent to the code following it.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+76 -24) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Attempt #2: Expanded upon a comment in order to make it pertinent to the code following it.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+82 -24) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
