Add stamping and fix configuration for the Perforce trigger script.

Review Request #13046 — Created May 15, 2023 and submitted

Information

RBTools
release-4.x

Reviewers

The Perforce trigger script can now stamp changesets with the review
request URL when the change is approved and submitted. This will only be
stamped if not already stamped.

There are also fixes for configuring the API user/token used for
communicating with Review Board.

Tested all combinations of options locally.

Verified the fixes and improvements with a customer.

Summary ID
Add stamping and fix configuration for the Perforce trigger script.
The Perforce trigger script can now stamp changesets with the review request URL when the change is approved and submitted. This will only be stamped if not already stamped. There are also fixes for configuring the API user/token used for communicating with Review Board.
3182a44d39b04d7a4a037604e170b4039b6c73b9
Description From Last Updated

Can we put a blank line in between here? This kind of looks like the comment about the ID applies …

daviddavid
david
  1. 
      
  2. contrib/tools/p4-trigger-script (Diff revision 1)
     
     
     
    Show all issues

    Can we put a blank line in between here? This kind of looks like the comment about the ID applies to the STAMP_CHANGES block.

    1. Expanding the comment a bit.

  3. 
      
chipx86
chipx86
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.x (3ce7783)