Summary

Add stamping and fix configuration for the Perforce trigger script.

Review Request #13046 — Created May 15, 2023 and submitted May 19, 2023, 4:20 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The Perforce trigger script can now stamp changesets with the review
request URL when the change is approved and submitted. This will only be
stamped if not already stamped.

There are also fixes for configuring the API user/token used for
communicating with Review Board.

Testing Done

Tested all combinations of options locally.

Verified the fixes and improvements with a customer.

Commits

Summary	ID
Add stamping and fix configuration for the Perforce trigger script. The Perforce trigger script can now stamp changesets with the review request URL when the change is approved and submitted. This will only be stamped if not already stamped. There are also fixes for configuring the API user/token used for communicating with Review Board.	3182a44d39b04d7a4a037604e170b4039b6c73b9

Issues

Description	From	Last Updated
Can we put a blank line in between here? This kind of looks like the comment about the ID applies …	david	May 15, 2023, 10:22 p.m.

flake8 passed.

JSHint passed.

Ship it!

contrib/tools/p4-trigger-script (Diff revision 1)

The issue has been resolved. Show all issues

Can we put a blank line in between here? This kind of looks like the comment about the ID applies to the STAMP_CHANGES block.

chipx86 May 15, 2023, 10:23 p.m.
```
Expanding the comment a bit.
```

Change Summary:

Expanded upon a comment in order to make it pertinent to the code following it.

Commits:

	Summary	ID
	Add stamping and fix configuration for the Perforce trigger script. The Perforce trigger script can now stamp changesets with the review request URL when the change is approved and submitted. This will only be stamped if not already stamped. There are also fixes for configuring the API user/token used for communicating with Review Board.	522cddc52782269b5673e27d9259661f133bab3e
	Add stamping and fix configuration for the Perforce trigger script. The Perforce trigger script can now stamp changesets with the review request URL when the change is approved and submitted. This will only be stamped if not already stamped. There are also fixes for configuring the API user/token used for communicating with Review Board.	a1a034c063096f11e5721427f20a7cadb351e061

Diff:

Revision 2 (+76 -24)

Show changes

contrib/tools/p4-trigger-script

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Attempt #2: Expanded upon a comment in order to make it pertinent to the code following it.

Commits:

	Summary	ID
	Add stamping and fix configuration for the Perforce trigger script. The Perforce trigger script can now stamp changesets with the review request URL when the change is approved and submitted. This will only be stamped if not already stamped. There are also fixes for configuring the API user/token used for communicating with Review Board.	a1a034c063096f11e5721427f20a7cadb351e061
	Add stamping and fix configuration for the Perforce trigger script. The Perforce trigger script can now stamp changesets with the review request URL when the change is approved and submitted. This will only be stamped if not already stamped. There are also fixes for configuring the API user/token used for communicating with Review Board.	3182a44d39b04d7a4a037604e170b4039b6c73b9

Diff:

Revision 3 (+82 -24)

Show changes

contrib/tools/p4-trigger-script

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (3ce7783)