Save open review reply editors before publishing.
Review Request #13044 — Created May 12, 2023 and submitted — Latest diff uploaded
This change adds review reply editors to the set of things that will be
saved when publishing new content from the unified banner. Incidentally,
it appears that the old draft reply banners never did this (meaning we'd
fail to save new reply content when hitting the publish button).This change also fixes up a couple regressions in event names for legacy
actions which are hidden when the unified banner feature is enabled.
- Ran js-tests.
- Set some pending data in replies to review headers and comments and
then published from the unified banner. Saw the open editors save
correctly and the reloaded page contain the new content.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
Commits
Files
| reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js |
|---|
| reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewablePageView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts |
|---|