Save open review reply editors before publishing.

Review Request #13044 — Created May 12, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change adds review reply editors to the set of things that will be
saved when publishing new content from the unified banner. Incidentally,
it appears that the old draft reply banners never did this (meaning we'd
fail to save new reply content when hitting the publish button).

This change also fixes up a couple regressions in event names for legacy
actions which are hidden when the unified banner feature is enabled.

  • Ran js-tests.
  • Set some pending data in replies to review headers and comments and
    then published from the unified banner. Saw the open editors save
    correctly and the reloaded page contain the new content.
Summary ID
Save open review reply editors before publishing.
This change adds review reply editors to the set of things that will be saved when publishing new content from the unified banner. Incidentally, it appears that the old draft reply banners never did this (meaning we'd fail to save new reply content when hitting the publish button). This change also fixes up a couple regressions in event names for legacy actions which are hidden when the unified banner feature is enabled. Testing Done: - Ran js-tests. - Set some pending data in replies to review headers and comments and then published from the unified banner. Saw the open editors save correctly and the reloaded page contain the new content.
16d1ae7ad2c9c9bacc41e08573ea7a4e5a9f086f
Description From Last Updated

Missing semicolon. Column: 15 Error code: W033

reviewbotreviewbot

This looks like it could fit on one line?

maubinmaubin

Why not keep oldStatus as the name? Seems inconsistent now.

chipx86chipx86

Missing Args.

chipx86chipx86

Missing typing information.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
maubin
  1. 
      
  2. This looks like it could fit on one line?

    1. Not quite (84 columns)

  3. 
      
chipx86
  1. 
      
  2. Why not keep oldStatus as the name? Seems inconsistent now.

    1. I was trying to get this to wrap in a way which didn't make eslint super grouchy about indentation. I'll just undo this part of the change.

  3. Missing Args.

  4. Missing typing information.

  5. 
      
david
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (9ea5982)
Loading...