Summary

Save open review reply editors before publishing.

Review Request #13044 — Created May 12, 2023 and submitted May 19, 2023, 2:49 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change also fixes up a couple regressions in event names for legacy
actions which are hidden when the unified banner feature is enabled.

Testing Done


Ran js-tests.
Set some pending data in replies to review headers and comments and

  then published from the unified banner. Saw the open editors save

  correctly and the reloaded page contain the new content.

Commits

Summary	ID
Save open review reply editors before publishing. This change adds review reply editors to the set of things that will be saved when publishing new content from the unified banner. Incidentally, it appears that the old draft reply banners never did this (meaning we'd fail to save new reply content when hitting the publish button). This change also fixes up a couple regressions in event names for legacy actions which are hidden when the unified banner feature is enabled. Testing Done: - Ran js-tests. - Set some pending data in replies to review headers and comments and then published from the unified banner. Saw the open editors save correctly and the reloaded page contain the new content.	16d1ae7ad2c9c9bacc41e08573ea7a4e5a9f086f

Summary

Save open review reply editors before publishing.

This change adds review reply editors to the set of things that will be saved when publishing new content from the unified banner. Incidentally, it appears that the old draft reply banners never did this (meaning we'd fail to save new reply content when hitting the publish button). This change also fixes up a couple regressions in event names for legacy actions which are hidden when the unified banner feature is enabled. Testing Done: - Ran js-tests. - Set some pending data in replies to review headers and comments and then published from the unified banner. Saw the open editors save correctly and the reloaded page contain the new content.

16d1ae7ad2c9c9bacc41e08573ea7a4e5a9f086f

Issues

Description	From	Last Updated
Missing semicolon. Column: 15 Error code: W033	reviewbot	May 12, 2023, 10:59 a.m.
This looks like it could fit on one line?	maubin	May 12, 2023, 2:04 p.m.
Why not keep oldStatus as the name? Seems inconsistent now.	chipx86	May 12, 2023, 2:06 p.m.
Missing Args.	chipx86	May 12, 2023, 2:06 p.m.
Missing typing information.	chipx86	May 12, 2023, 2:06 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Missing semicolon.

Column: 15
Error code: W033
```

Commits:

	Summary	ID
	Save open review reply editors before publishing. This change adds review reply editors to the set of things that will be saved when publishing new content from the unified banner. Incidentally, it appears that the old draft reply banners never did this (meaning we'd fail to save new reply content when hitting the publish button). Testing Done: - Ran js-tests. - Set some pending data in replies to review headers and comments and then published from the unified banner. Saw the open editors save correctly and the reloaded page contain the new content.	ab8463318b594f373b60a655d3c759c439750aae
	Save open review reply editors before publishing. This change adds review reply editors to the set of things that will be saved when publishing new content from the unified banner. Incidentally, it appears that the old draft reply banners never did this (meaning we'd fail to save new reply content when hitting the publish button). This change also fixes up a couple regressions in event names for legacy actions which are hidden when the unified banner feature is enabled. Testing Done: - Ran js-tests. - Set some pending data in replies to review headers and comments and then published from the unified banner. Saw the open editors save correctly and the reloaded page contain the new content.	69108de86ebf1758d74f319fdaf6b9a23079000e

Diff:

Revision 2 (+190 -26)

Show changes

	reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js
	reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
	reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
	reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js (Diff revision 2)
The issue has been dropped. Show all issues
```
This looks like it could fit on one line?
```
1. david May 12, 2023, 2:06 p.m.
  Not quite (84 columns)

reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

Why not keep oldStatus as the name? Seems inconsistent now.

david May 12, 2023, 2:06 p.m.

I was trying to get this to wrap in a way which didn't make eslint super grouchy about indentation. I'll just undo this part of the change.

reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2)

The issue has been resolved. Show all issues

Missing Args.

reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing typing information.
```

Commits:

	Summary	ID
	Save open review reply editors before publishing. This change adds review reply editors to the set of things that will be saved when publishing new content from the unified banner. Incidentally, it appears that the old draft reply banners never did this (meaning we'd fail to save new reply content when hitting the publish button). This change also fixes up a couple regressions in event names for legacy actions which are hidden when the unified banner feature is enabled. Testing Done: - Ran js-tests. - Set some pending data in replies to review headers and comments and then published from the unified banner. Saw the open editors save correctly and the reloaded page contain the new content.	69108de86ebf1758d74f319fdaf6b9a23079000e
	Save open review reply editors before publishing. This change adds review reply editors to the set of things that will be saved when publishing new content from the unified banner. Incidentally, it appears that the old draft reply banners never did this (meaning we'd fail to save new reply content when hitting the publish button). This change also fixes up a couple regressions in event names for legacy actions which are hidden when the unified banner feature is enabled. Testing Done: - Ran js-tests. - Set some pending data in replies to review headers and comments and then published from the unified banner. Saw the open editors save correctly and the reloaded page contain the new content.	16d1ae7ad2c9c9bacc41e08573ea7a4e5a9f086f

Diff:

Revision 3 (+198 -20)

Show changes

	reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js
	reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
	reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
	reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (9ea5982)