flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js (Diff revision 1) Show all issues
Save open review reply editors before publishing.
Review Request #13044 — Created May 12, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change adds review reply editors to the set of things that will be
saved when publishing new content from the unified banner. Incidentally,
it appears that the old draft reply banners never did this (meaning we'd
fail to save new reply content when hitting the publish button).This change also fixes up a couple regressions in event names for legacy
actions which are hidden when the unified banner feature is enabled.
- Ran js-tests.
- Set some pending data in replies to review headers and comments and
then published from the unified banner. Saw the open editors save
correctly and the reloaded page contain the new content.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+190 -26) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js (Diff revision 2) This looks like it could fit on one line?
-
-
reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js (Diff revision 2) Why not keep
oldStatusas the name? Seems inconsistent now. -
-
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2) Missing typing information.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+198 -20) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.