Add typing and docs for all functionality in the base command classes.

 






 

 


  Review Request #13038
  —
  Created May 10, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  RBTools
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
BaseCommand, BaseMultiCommand, and BaseSubCommand now include

typing for all code, and modernized documentation.


This has required some small typing fixes throughout the codebase, but

has also found a few typing and logic errors that are being fixed. For

instance, BaseCommand._init_server_url() received a fix to avoid

crashing if repository information couldn't be found.


Some legacy Python 2 conditional code has been removed. There are some

other deprecated code paths that don't have proper typing, but those

will be going away in a separate change.

 








  


 
 

  
Unit tests pass.


Tested posting several review requests for review, including this one.

 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add typing and docs for all functionality in the base command classes.
     
`BaseCommand`, `BaseMultiCommand`, and `BaseSubCommand` now include
typing for all code, and modernized documentation.

This has required some small typing fixes throughout the codebase, but
has also found a few typing and logic errors that are being fixed. For
instance, `BaseCommand._init_server_url()` received a fix to avoid
crashing if repository information couldn't be found.

Some legacy Python 2 conditional code has been removed. There are some
other deprecated code paths that don't have proper typing, but those
will be going away in a separate change.

    

   
  		
  8e9e0ac3b505ebbfba43c4295400e98a1dccd522
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/api/capabilities.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/api/client.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/api/resource.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/api/transport/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/api/transport/sync.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/clients/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/commands/base/commands.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...