Add typing and docs for all functionality in the base command classes.

Review Request #13038 — Created May 10, 2023 and submitted

Information

RBTools
release-5.x

Reviewers

BaseCommand, BaseMultiCommand, and BaseSubCommand now include
typing for all code, and modernized documentation.

This has required some small typing fixes throughout the codebase, but
has also found a few typing and logic errors that are being fixed. For
instance, BaseCommand._init_server_url() received a fix to avoid
crashing if repository information couldn't be found.

Some legacy Python 2 conditional code has been removed. There are some
other deprecated code paths that don't have proper typing, but those
will be going away in a separate change.

Unit tests pass.

Tested posting several review requests for review, including this one.

Summary ID
Add typing and docs for all functionality in the base command classes.
`BaseCommand`, `BaseMultiCommand`, and `BaseSubCommand` now include typing for all code, and modernized documentation. This has required some small typing fixes throughout the codebase, but has also found a few typing and logic errors that are being fixed. For instance, `BaseCommand._init_server_url()` received a fix to avoid crashing if repository information couldn't be found. Some legacy Python 2 conditional code has been removed. There are some other deprecated code paths that don't have proper typing, but those will be going away in a separate change.
8e9e0ac3b505ebbfba43c4295400e98a1dccd522
Description From Last Updated

'typing.Dict' imported but unused Column: 1 Error code: F401

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (14fae2d)
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (14fae2d)