flake8
failed.
JSHint
passed.
flake8
-
rbtools/clients/__init__.py (Diff revision 1) Show all issues
Add typing and docs for all functionality in the base command classes.
Review Request #13038 — Created May 10, 2023 and submitted
| Information | |
|---|---|
| chipx86 | |
| RBTools | |
| release-5.x | |
| Reviewers | |
| rbtools | |
BaseCommand,BaseMultiCommand, andBaseSubCommandnow include
typing for all code, and modernized documentation.This has required some small typing fixes throughout the codebase, but
has also found a few typing and logic errors that are being fixed. For
instance,BaseCommand._init_server_url()received a fix to avoid
crashing if repository information couldn't be found.Some legacy Python 2 conditional code has been removed. There are some
other deprecated code paths that don't have proper typing, but those
will be going away in a separate change.
Unit tests pass.
Tested posting several review requests for review, including this one.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
'typing.Dict' imported but unused Column: 1 Error code: F401 |
 reviewbot
|
Change Summary:
Removed an unused import.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+588 -192) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
