rbtools/clients/__init__.py (Diff revision 1)Show all issues
Review Request #13038 — Created May 10, 2023 and submitted
typing for all code, and modernized documentation.
This has required some small typing fixes throughout the codebase, but
has also found a few typing and logic errors that are being fixed. For
BaseCommand._init_server_url()received a fix to avoid
crashing if repository information couldn't be found.
Some legacy Python 2 conditional code has been removed. There are some
other deprecated code paths that don't have proper typing, but those
will be going away in a separate change.
Unit tests pass.
Tested posting several review requests for review, including this one.
'typing.Dict' imported but unused Column: 1 Error code: F401
Removed an unused import.
Revision 2 (+588 -192)