Update code to consume the new RBToolsConfig for config access.

Review Request #13037 — Created May 10, 2023 and submitted

Information

RBTools
release-5.x

Reviewers

RBToolsConfig is now used throughout the codebase.
BaseCommand.config is now an instance of this, options now take this,
and base command support accesses state on this without the need for
conditional checks.

Options benefit the most. We can now get rid of all the custom
default= arguments on any option backed by a config key. The option
support has always based the default on the config, but only to reflect
values specified in config files. Since RBToolsConfig now manages all
defaults, the ones on options can be removed. That will happen in
another change, but the classes are prepared for it.

Unit tests pass.

I've been using this locally, and have used it to post this change and
other related changes today.

Summary ID
Update code to consume the new RBToolsConfig for config access.
`RBToolsConfig` is now used throughout the codebase. `BaseCommand.config` is now an instance of this, options now take this, and base command support accesses state on this without the need for conditional checks. Options benefit the most. We can now get rid of all the custom `default=` arguments on any option backed by a config key. The option support has always based the default on the config, but only to reflect values specified in config files. Since `RBToolsConfig` now manages all defaults, the ones on options can be removed. That will happen in another change, but the classes are prepared for it.
6a20ec8a4185feeff4313e16dd8a77582e3a8c24
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (b6455ff)