chipx86 got a fish trophy!

Summary

Add type hints for attributes on BaseCommand classes.

Review Request #13031 — Created May 10, 2023 and submitted May 19, 2023, 4:14 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This ensures that all the attributes on BaseCommand,
BaseMultiCommand, and BaseSubCommand have type hints on the
attributes. This avoids the problem where type checkers complain when
subclasses define attributes of an "invalid type" due to thinking
default values are literals.

Testing Done

Unit tests pass.

Verified the type checker was happy for all subclasses.

Commits

Summary	ID
Add type hints for attributes on BaseCommand classes. This ensures that all the attributes on `BaseCommand`, `BaseMultiCommand`, and `BaseSubCommand` have type hints on the attributes. This avoids the problem where type checkers complain when subclasses define attributes of an "invalid type" due to thinking default values are literals.	6d5351f06dc262291d5910b72436a9cb47cf9572

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (c9d9d10)