Fish Trophy

chipx86 got a fish trophy!

Fish Trophy

Add type hints for attributes on BaseCommand classes.

Review Request #13031 — Created May 10, 2023 and submitted

Information

RBTools
release-5.x

Reviewers

This ensures that all the attributes on BaseCommand,
BaseMultiCommand, and BaseSubCommand have type hints on the
attributes. This avoids the problem where type checkers complain when
subclasses define attributes of an "invalid type" due to thinking
default values are literals.

Unit tests pass.

Verified the type checker was happy for all subclasses.

Summary ID
Add type hints for attributes on BaseCommand classes.
This ensures that all the attributes on `BaseCommand`, `BaseMultiCommand`, and `BaseSubCommand` have type hints on the attributes. This avoids the problem where type checkers complain when subclasses define attributes of an "invalid type" due to thinking default values are literals.
6d5351f06dc262291d5910b72436a9cb47cf9572
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (c9d9d10)