Convert InlineEditorView to spina.

 






 

 


  Review Request #13026
  —
  Created May 9, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change converts the InlineEditorView (and subclasses) to spina and

TypeScript. This also adds a new test suite for the inline editor (we

previously only had tests for the date and datetime versions).

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Used various inline editors in the Review Board UI.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert InlineEditorView to spina.
     
This change converts the InlineEditorView (and subclasses) to spina and
TypeScript. This also adds a new test suite for the inline editor (we
previously only had tests for the date and datetime versions).

Testing Done:
- Ran js-tests.
- Used various inline editors in the Review Board UI.

    

   
  		
  c00d2a9418dc0662812b7c52f8079e94be3b3e46
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/tests/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/inlineEditorView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/dateInlineEditorViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/dateTimeInlineEditorViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/inlineEditorViewTests.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...