Summary

Convert InlineEditorView to spina.

Review Request #13026 — Created May 9, 2023 and submitted May 19, 2023, 2:58 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the InlineEditorView (and subclasses) to spina and
TypeScript. This also adds a new test suite for the inline editor (we
previously only had tests for the date and datetime versions).

Testing Done


Ran js-tests.
Used various inline editors in the Review Board UI.

Commits

Summary	ID
Convert InlineEditorView to spina. This change converts the InlineEditorView (and subclasses) to spina and TypeScript. This also adds a new test suite for the inline editor (we previously only had tests for the date and datetime versions). Testing Done: - Ran js-tests. - Used various inline editors in the Review Board UI.	c00d2a9418dc0662812b7c52f8079e94be3b3e46

Issues

Description	From	Last Updated
Typo: "te" -> "to"	maubin	May 16, 2023, 5:34 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Forgot some TODO items

Commits:

	Summary	ID
	Convert InlineEditorView to spina. This change converts the InlineEditorView (and subclasses) to spina and TypeScript. This also adds a new test suite for the inline editor (we previously only had tests for the date and datetime versions). Testing Done: - Ran js-tests. - Used various inline editors in the Review Board UI.	129b61d6ebc725744376469ea118f7838c9f3f9a
	Convert InlineEditorView to spina. This change converts the InlineEditorView (and subclasses) to spina and TypeScript. This also adds a new test suite for the inline editor (we previously only had tests for the date and datetime versions). Testing Done: - Ran js-tests. - Used various inline editors in the Review Board UI.	c00d2a9418dc0662812b7c52f8079e94be3b3e46

Diff:

Revision 2 (+1332 -578)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/tests/index.ts
	reviewboard/static/rb/js/ui/index.ts
	reviewboard/static/rb/js/ui/views/inlineEditorView.es6.js
	reviewboard/static/rb/js/ui/views/tests/dateInlineEditorViewTests.es6.js
	reviewboard/static/rb/js/ui/views/tests/dateTimeInlineEditorViewTests.es6.js
	reviewboard/static/rb/js/ui/views/tests/index.ts
	reviewboard/static/rb/js/ui/views/tests/inlineEditorViewTests.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Thanks for updating this.
```
reviewboard/static/rb/js/ui/views/inlineEditorView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo: "te" -> "to"
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (cf6ba22)