flake8
passed.
JSHint
passed.
Convert ReviewRequestEditorView to spina.
Review Request #13025 — Created May 8, 2023 and submitted
This change converts the ReviewRequestEditorView to spina and
TypeScript.
- Ran js-tests.
- Edited some review requests.
| Summary | ID |
|---|---|
| 8a370067e58927f037fe477c224a713bfcad6d93 |
| Description | From | Last Updated |
|---|---|---|
|
Doesn't look like both of these should be here. Also, I forget, did we determine if xgettext can find these … |
 chipx86
|
|
|
This isn't public API at this point, so it may be less important, but we've been starting to thoroughly document … |
chipx86
|
|
|
No need to return here. |
chipx86
|
|
|
Missing docs/typing for options. |
chipx86
|
|
|
This can wrap, like so: const msg = _` Line line line.. line line line. `; All whitespace will be … |
chipx86
|
|
|
This can also wrap. |
chipx86
|
|
|
This can also wrap. |
chipx86
|
- Commits:
-
Summary ID a27c4a9e99635ef3078273d01baa08ed91d8e031 b07208db304db6e30ca0dcf0579000878292eac0 - Diff:
-
Revision 2 (+944 -712)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
Doesn't look like both of these should be here.
Also, I forget, did we determine if xgettext can find these in template literals?
-
This isn't public API at this point, so it may be less important, but we've been starting to thoroughly document our attributes. Might be nice to do that in this change as well.
-
-
-
This can wrap, like so:
const msg = _` Line line line.. line line line. `;All whitespace will be collapsed/trimmed.
-
-
- Commits:
-
Summary ID b07208db304db6e30ca0dcf0579000878292eac0 8a370067e58927f037fe477c224a713bfcad6d93 - Diff:
-
Revision 3 (+1018 -730)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.