Convert ReviewRequestEditorView to spina.
Review Request #13025 — Created May 8, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
This change converts the ReviewRequestEditorView to spina and
TypeScript.
- Ran js-tests.
- Edited some review requests.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
Doesn't look like both of these should be here. Also, I forget, did we determine if xgettext can find these … |
|
|
This isn't public API at this point, so it may be less important, but we've been starting to thoroughly document … |
|
|
No need to return here. |
|
|
Missing docs/typing for options. |
|
|
This can wrap, like so: const msg = _` Line line line.. line line line. `; All whitespace will be … |
|
|
This can also wrap. |
|
|
This can also wrap. |
|
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+944 -712) |
Checks run (2 succeeded)
-
-
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2) Doesn't look like both of these should be here.
Also, I forget, did we determine if xgettext can find these in template literals?
-
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2) This isn't public API at this point, so it may be less important, but we've been starting to thoroughly document our attributes. Might be nice to do that in this change as well.
-
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2) No need to return here.
-
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2) Missing docs/typing for
options
. -
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2) This can wrap, like so:
const msg = _` Line line line.. line line line. `;
All whitespace will be collapsed/trimmed.
-
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2) This can also wrap.
-
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 2) This can also wrap.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1018 -730) |