Convert ReviewRequestEditorView to spina.

Review Request #13025 — Created May 8, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change converts the ReviewRequestEditorView to spina and
TypeScript.

  • Ran js-tests.
  • Edited some review requests.
Summary ID
Convert ReviewRequestEditorView to spina.
This change converts the ReviewRequestEditorView to spina and TypeScript. Testing Done: - Ran js-tests. - Edited some review requests.
8a370067e58927f037fe477c224a713bfcad6d93
Description From Last Updated

Doesn't look like both of these should be here. Also, I forget, did we determine if xgettext can find these …

chipx86chipx86

This isn't public API at this point, so it may be less important, but we've been starting to thoroughly document …

chipx86chipx86

No need to return here.

chipx86chipx86

Missing docs/typing for options.

chipx86chipx86

This can wrap, like so: const msg = _` Line line line.. line line line. `; All whitespace will be …

chipx86chipx86

This can also wrap.

chipx86chipx86

This can also wrap.

chipx86chipx86
david
chipx86
  1. 
      
  2. Doesn't look like both of these should be here.

    Also, I forget, did we determine if xgettext can find these in template literals?

  3. This isn't public API at this point, so it may be less important, but we've been starting to thoroughly document our attributes. Might be nice to do that in this change as well.

  4. No need to return here.

  5. Missing docs/typing for options.

  6. This can wrap, like so:

    const msg = _`
        Line line line..
        line line line.
    `;
    

    All whitespace will be collapsed/trimmed.

  7. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (cba4a15)
Loading...