Summary

Convert ReviewRequestEditor model to spina.

Review Request #13024 — Created May 8, 2023 and submitted May 19, 2023, 2:58 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the ReviewRequestEditor model to spina and
TypeScript.

Testing Done


Ran js-tests.
Edited review requests.

Commits

Summary	ID
Convert ReviewRequestEditor model to spina. This change converts the ReviewRequestEditor model to spina and TypeScript. Testing Done: - Ran js-tests. - Edited review requests.	dd6cfe9420e5c6a99b67384339844c3071d2aafe

Issues

Description	From	Last Updated
Worth converting to a Spina collection? Or just keeping it Backbone for now?	chipx86	May 17, 2023, 1:41 p.m.
Can we define an interface for this map?	chipx86	May 17, 2023, 1:42 p.m.
This can be removed now.	chipx86	May 17, 2023, 1:42 p.m.
Small thing, but this might be a bit nicer as: confirm(_` ... text here ... `); That way, the text …	chipx86	May 19, 2023, 2:55 p.m.
Trailing newline here.	chipx86	May 19, 2023, 2:55 p.m.
Since this is public API, can we make an interface for this as well?	chipx86	May 17, 2023, 1:43 p.m.
While here, we can make this wrap. _ will condense any whitespace (newlines or otherwise) to spaces. It might be …	chipx86	May 17, 2023, 1:44 p.m.
Technically, the capital R places it above the other Review* ones.	chipx86	May 17, 2023, 1:45 p.m.
These should be swapped (capital letters sort before lowercase).	chipx86	May 17, 2023, 1:45 p.m.
Swap these (alphabetical order).	chipx86	May 17, 2023, 1:45 p.m.
Swap these (alphabetical order).	chipx86	May 17, 2023, 1:46 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1)

The issue has been dropped. Show all issues

Worth converting to a Spina collection? Or just keeping it Backbone for now?

david May 17, 2023, 1:47 p.m.

I think I'll keep it for now. I'll convert it when I convert the resource.

reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we define an interface for this map?
```

reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1)

The issue has been resolved. Show all issues

This can be removed now.

reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1)

The issue has been resolved. Show all issues

Since this is public API, can we make an interface for this as well?

reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1)

The issue has been resolved. Show all issues

While here, we can make this wrap. _ will condense any whitespace (newlines or otherwise) to spaces.

It might be nicer to separate the confirm() call from the conditional as well.

reviewboard/static/rb/js/reviews/index.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Technically, the capital R places it above the other Review* ones.
```
reviewboard/static/rb/js/reviews/models/tests/index.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
These should be swapped (capital letters sort before lowercase).
```
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Swap these (alphabetical order).
```
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Swap these (alphabetical order).
```

Commits:

	Summary	ID
	Convert ReviewRequestEditor model to spina. This change converts the ReviewRequestEditor model to spina and TypeScript. Testing Done: - Ran js-tests. - Edited review requests.	8cd4b299851c16bc01b27fccf8faf48fa0097f81
	Convert ReviewRequestEditor model to spina. This change converts the ReviewRequestEditor model to spina and TypeScript. Testing Done: - Ran js-tests. - Edited review requests.	3872d80e49c61953c898870ca704042dda173c8e

Diff:

Revision 2 (+612 -588)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/reviews/models/commentEditorModel.ts
	reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js
	reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts
	reviewboard/static/rb/js/reviews/models/unifiedBanner.ts
	reviewboard/static/rb/js/reviews/models/tests/index.ts
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

Small thing, but this might be a bit nicer as:

confirm(_`
    ... text here ...
`);

That way, the text all stays away from the syntax nicely.

reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Trailing newline here.
```

Commits:

	Summary	ID
	Convert ReviewRequestEditor model to spina. This change converts the ReviewRequestEditor model to spina and TypeScript. Testing Done: - Ran js-tests. - Edited review requests.	3872d80e49c61953c898870ca704042dda173c8e
	Convert ReviewRequestEditor model to spina. This change converts the ReviewRequestEditor model to spina and TypeScript. Testing Done: - Ran js-tests. - Edited review requests.	dd6cfe9420e5c6a99b67384339844c3071d2aafe

Diff:

Revision 3 (+614 -588)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/reviews/models/commentEditorModel.ts
	reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js
	reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts
	reviewboard/static/rb/js/reviews/models/unifiedBanner.ts
	reviewboard/static/rb/js/reviews/models/tests/index.ts
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (17c320a)