flake8
passed.
JSHint
passed.
Convert ReviewRequestEditor model to spina.
Review Request #13024 — Created May 8, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change converts the ReviewRequestEditor model to spina and
TypeScript.
- Ran js-tests.
- Edited review requests.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Worth converting to a Spina collection? Or just keeping it Backbone for now? |
 chipx86
|
|
|
Can we define an interface for this map? |
chipx86
|
|
|
This can be removed now. |
chipx86
|
|
|
Small thing, but this might be a bit nicer as: confirm(_` ... text here ... `); That way, the text … |
chipx86
|
|
|
Trailing newline here. |
chipx86
|
|
|
Since this is public API, can we make an interface for this as well? |
chipx86
|
|
|
While here, we can make this wrap. _ will condense any whitespace (newlines or otherwise) to spaces. It might be … |
chipx86
|
|
|
Technically, the capital R places it above the other Review* ones. |
chipx86
|
|
|
These should be swapped (capital letters sort before lowercase). |
chipx86
|
|
|
Swap these (alphabetical order). |
chipx86
|
|
|
Swap these (alphabetical order). |
chipx86
|
-
-
reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1) Worth converting to a Spina collection? Or just keeping it Backbone for now?
-
reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1) Can we define an interface for this map?
-
reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1) This can be removed now.
-
reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1) Since this is public API, can we make an interface for this as well?
-
reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revision 1) While here, we can make this wrap.
_will condense any whitespace (newlines or otherwise) to spaces.It might be nicer to separate the
confirm()call from the conditional as well. -
reviewboard/static/rb/js/reviews/index.ts (Diff revision 1) Technically, the capital R places it above the other Review* ones.
-
reviewboard/static/rb/js/reviews/models/tests/index.ts (Diff revision 1) These should be swapped (capital letters sort before lowercase).
-
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1) Swap these (alphabetical order).
-
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 1) Swap these (alphabetical order).
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+612 -588) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revisions 1 - 2) Small thing, but this might be a bit nicer as:
confirm(_` ... text here ... `);That way, the text all stays away from the syntax nicely.
-
reviewboard/static/rb/js/reviews/models/reviewRequestEditor.ts (Diff revisions 1 - 2) Trailing newline here.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+614 -588) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.