Convert ReviewRequestEditor model to spina.

Review Request #13024 — Created May 8, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change converts the ReviewRequestEditor model to spina and
TypeScript.

  • Ran js-tests.
  • Edited review requests.
Summary ID
Convert ReviewRequestEditor model to spina.
This change converts the ReviewRequestEditor model to spina and TypeScript. Testing Done: - Ran js-tests. - Edited review requests.
dd6cfe9420e5c6a99b67384339844c3071d2aafe
Description From Last Updated

Worth converting to a Spina collection? Or just keeping it Backbone for now?

chipx86chipx86

Can we define an interface for this map?

chipx86chipx86

This can be removed now.

chipx86chipx86

Small thing, but this might be a bit nicer as: confirm(_` ... text here ... `); That way, the text …

chipx86chipx86

Trailing newline here.

chipx86chipx86

Since this is public API, can we make an interface for this as well?

chipx86chipx86

While here, we can make this wrap. _ will condense any whitespace (newlines or otherwise) to spaces. It might be …

chipx86chipx86

Technically, the capital R places it above the other Review* ones.

chipx86chipx86

These should be swapped (capital letters sort before lowercase).

chipx86chipx86

Swap these (alphabetical order).

chipx86chipx86

Swap these (alphabetical order).

chipx86chipx86
chipx86
  1. 
      
  2. Worth converting to a Spina collection? Or just keeping it Backbone for now?

    1. I think I'll keep it for now. I'll convert it when I convert the resource.

  3. Can we define an interface for this map?

  4. This can be removed now.

  5. Since this is public API, can we make an interface for this as well?

  6. While here, we can make this wrap. _ will condense any whitespace (newlines or otherwise) to spaces.

    It might be nicer to separate the confirm() call from the conditional as well.

  7. reviewboard/static/rb/js/reviews/index.ts (Diff revision 1)
     
     
     
     

    Technically, the capital R places it above the other Review* ones.

  8. These should be swapped (capital letters sort before lowercase).

  9. Swap these (alphabetical order).

  10. Swap these (alphabetical order).

  11. 
      
david
chipx86
  1. 
      
  2. Small thing, but this might be a bit nicer as:

    confirm(_`
        ... text here ...
    `);
    

    That way, the text all stays away from the syntax nicely.

  3. Trailing newline here.

  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (17c320a)
Loading...