flake8
passed.
JSHint
passed.
Improve the JavaScript extensions docs.
Review Request #13018 — Created May 9, 2023 and submitted
| Information | |
|---|---|
| maubin | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This improves the JavaScript extensions docs, mostly by modernizing the
JavaScript code in the examples and fixing up some typos.
Built the docs.
| Summary |
|---|
| Description | From | Last Updated |
|---|---|---|
|
To keep this is internal to the module, we'll want to use const here. This applies to the other examples … |
 chipx86
|
|
|
These won't be modified, so we should use const. Also, to comply with our modern JavaScript styling, we should have … |
chipx86
|
|
|
The old wording was incorrect. This isn't related to the Comment Dialog, but rather comment fields within the Review Dialog. |
chipx86
|
|
|
Same note as above. |
chipx86
|
-
-
docs/manual/extending/extensions/js-hooks/comment-dialog-hook.rst (Diff revision 1) To keep this is internal to the module, we'll want to use
consthere.This applies to the other examples as well.
-
docs/manual/extending/extensions/js-hooks/comment-dialog-hook.rst (Diff revision 1) These won't be modified, so we should use
const. Also, to comply with our modern JavaScript styling, we should have oneconst/letper variable. -
docs/manual/extending/extensions/js-hooks/review-dialog-comment-hook.rst (Diff revision 1) The old wording was incorrect. This isn't related to the Comment Dialog, but rather comment fields within the Review Dialog.
-
docs/manual/extending/extensions/js-hooks/review-dialog-comment-hook.rst (Diff revision 1) Same note as above.
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+96 -84) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
