This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-6.x (9c91b9e)

Summary

Port review request field views to spina.

Review Request #13017 — Created May 5, 2023 and submitted 2 years ago — Latest diff uploaded 2 years ago

Information

Owner

david*

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

This change ports over all of the review request field views to spina
and TypeScript.

Testing Done


Ran js-tests.
Excercised various fields in the review request UI.
Verified that the change description field in the unified banner

  worked correctly.

Diff Revision 3 (Latest)

orig

Commits

First	Last	Summary	ID	Author
		Port review request field views to spina. This change ports over all of the review request field views to spina and TypeScript. Testing Done: - Ran js-tests. - Excercised various fields in the review request UI. - Verified that the change description field in the unified banner worked correctly.	8887e3904f46305eae9b88366548a9a96aba5ada	David Trowbridge

Files

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts Was reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
	reviewboard/static/rb/js/reviews/views/tests/index.ts
	reviewboard/static/rb/js/reviews/views/tests/reviewRequestFieldViewsTests.ts Was reviewboard/static/rb/js/views/tests/reviewRequestFieldViewsTests.es6.js

reviewboard/staticbundles.py

reviewboard/static/rb/js/reviews/index.ts

reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js

reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts

reviewboard/static/rb/js/reviews/views/tests/index.ts

reviewboard/static/rb/js/views/tests/reviewRequestFieldViewsTests.es6.js