flake8
passed.
JSHint
passed.
Port review request field views to spina.
Review Request #13017 — Created May 5, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change ports over all of the review request field views to spina
and TypeScript.
- Ran js-tests.
- Excercised various fields in the review request UI.
- Verified that the change description field in the unified banner
worked correctly.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Should these be made static? |
 chipx86
|
|
|
Should these be static? |
chipx86
|
|
|
Shoud be marked an instance variable. |
chipx86
|
|
|
So, Spina shouldn't require re-adding anything to prototypeAttrs if it was there in an ancestor. If it's failing without this, … |
chipx86
|
|
|
This should be static. |
chipx86
|
-
-
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1) Should these be made
static? -
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1) Should these be
static? -
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1) Shoud be marked an instance variable.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+982 -602) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revisions 1 - 2) So, Spina shouldn't require re-adding anything to
prototypeAttrsif it was there in an ancestor. If it's failing without this, can you file something in Asana for me to debug this? -
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revisions 1 - 2) This should be
static.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+982 -602) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.