Port review request field views to spina.

Review Request #13017 — Created May 5, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change ports over all of the review request field views to spina
and TypeScript.

  • Ran js-tests.
  • Excercised various fields in the review request UI.
  • Verified that the change description field in the unified banner
    worked correctly.
Summary ID
Port review request field views to spina.
This change ports over all of the review request field views to spina and TypeScript. Testing Done: - Ran js-tests. - Excercised various fields in the review request UI. - Verified that the change description field in the unified banner worked correctly.
8887e3904f46305eae9b88366548a9a96aba5ada
Description From Last Updated

Should these be made static?

chipx86chipx86

Should these be static?

chipx86chipx86

Shoud be marked an instance variable.

chipx86chipx86

So, Spina shouldn't require re-adding anything to prototypeAttrs if it was there in an ancestor. If it's failing without this, …

chipx86chipx86

This should be static.

chipx86chipx86
chipx86
  1. I didn't mark all cases, but it seems that more of these fields should be defined as static with prototypeAttrs set, so they're not reinitialized per-instance.

  2. Should these be made static?

  3. reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1)
     
     
     
     
     
     
     
     

    Should these be static?

  4. Shoud be marked an instance variable.

  5. 
      
david
chipx86
  1. 
      
  2. reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revisions 1 - 2)
     
     
     
     
     
     
     

    So, Spina shouldn't require re-adding anything to prototypeAttrs if it was there in an ancestor. If it's failing without this, can you file something in Asana for me to debug this?

    1. Definitely fails. Task filed.

  3. This should be static.

  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (9c91b9e)
Loading...