Summary

Port review request field views to spina.

Review Request #13017 — Created May 5, 2023 and submitted May 19, 2023, 2:58 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports over all of the review request field views to spina
and TypeScript.

Testing Done


Ran js-tests.
Excercised various fields in the review request UI.
Verified that the change description field in the unified banner

  worked correctly.

Commits

Summary	ID
Port review request field views to spina. This change ports over all of the review request field views to spina and TypeScript. Testing Done: - Ran js-tests. - Excercised various fields in the review request UI. - Verified that the change description field in the unified banner worked correctly.	8887e3904f46305eae9b88366548a9a96aba5ada

Issues

Description	From	Last Updated
Should these be made static?	chipx86	May 5, 2023, 10:31 p.m.
Should these be static?	chipx86	May 5, 2023, 10:31 p.m.
Shoud be marked an instance variable.	chipx86	May 5, 2023, 10:31 p.m.
So, Spina shouldn't require re-adding anything to prototypeAttrs if it was there in an ancestor. If it's failing without this, …	chipx86	May 17, 2023, 10:04 a.m.
This should be static.	chipx86	May 17, 2023, 9:52 a.m.

flake8 passed.

JSHint passed.

I didn't mark all cases, but it seems that more of these fields should be defined as static with prototypeAttrs set, so they're not reinitialized per-instance.

reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Should these be made static?
```

reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1)

The issue has been resolved. Show all issues

Should these be static?

reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Shoud be marked an instance variable.
```

Commits:

	Summary	ID
	Port review request field views to spina. This change ports over all of the review request field views to spina and TypeScript. Testing Done: - Ran js-tests. - Excercised various fields in the review request UI. - Verified that the change description field in the unified banner worked correctly.	ad6459c8d88af44546d579991df3f675558188b8
	Port review request field views to spina. This change ports over all of the review request field views to spina and TypeScript. Testing Done: - Ran js-tests. - Excercised various fields in the review request UI. - Verified that the change description field in the unified banner worked correctly.	dba527e0ae8648b3092f1861476c383376df1642

Diff:

Revision 2 (+982 -602)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
	reviewboard/static/rb/js/reviews/views/tests/index.ts
	reviewboard/static/rb/js/views/tests/reviewRequestFieldViewsTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revisions 1 - 2)

The issue has been dropped. Show all issues

So, Spina shouldn't require re-adding anything to prototypeAttrs if it was there in an ancestor. If it's failing without this, can you file something in Asana for me to debug this?

david May 17, 2023, 10:05 a.m.
```
Definitely fails. Task filed.
```

reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
This should be static.
```

Commits:

	Summary	ID
	Port review request field views to spina. This change ports over all of the review request field views to spina and TypeScript. Testing Done: - Ran js-tests. - Excercised various fields in the review request UI. - Verified that the change description field in the unified banner worked correctly.	dba527e0ae8648b3092f1861476c383376df1642
	Port review request field views to spina. This change ports over all of the review request field views to spina and TypeScript. Testing Done: - Ran js-tests. - Excercised various fields in the review request UI. - Verified that the change description field in the unified banner worked correctly.	8887e3904f46305eae9b88366548a9a96aba5ada

Diff:

Revision 3 (+982 -602)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
	reviewboard/static/rb/js/reviews/views/tests/index.ts
	reviewboard/static/rb/js/views/tests/reviewRequestFieldViewsTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (9c91b9e)