Fix warnings about comments at the top of interfaces.

 






 

 


  Review Request #13008
  —
  Created May 4, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  beanbag-eslint-plugin
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  beanbag-misc
 









 
 

  
 






 








 





  


 
 

  
The @typescript-eslint/eslint-plugin plugin recently gained a fix for

the spurious lines-around-comments warnings at the tops of interfaces

and other typescript-specific blocks. This change updates our plugin to

depend on that, and adds the new configuration to enable them.

 








  


 
 

  
Set up with a build of this and saw that I was no longer getting

warnings about comments that were the first line of an interface.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Fix warnings about comments at the top of interfaces.
     
The `@typescript-eslint/eslint-plugin` plugin recently gained a fix for
the spurious lines-around-comments warnings at the tops of interfaces
and other typescript-specific blocks. This change updates our plugin to
depend on that, and adds the new configuration to enable them.

Testing Done:
Set up with a build of this and saw that I was no longer getting
warnings about comments that were the first line of an interface.

    

   
  		
  6b2df58ef2eede23248efe13f3337d80cfaf5fd6
  David Trowbridge
 


 
  
 
 
  
   
    

     Fix warnings about comments at the top of interfaces.
     
The `@typescript-eslint/eslint-plugin` plugin recently gained a fix for
the spurious lines-around-comments warnings at the tops of interfaces
and other typescript-specific blocks. This change updates our plugin to
depend on that, and adds the new configuration to enable them.

Testing Done:
Set up with a build of this and saw that I was no longer getting
warnings about comments that were the first line of an interface.

    

   
  		
  158b23056031b212f19c57e2bb12e92b78befc0b
  David Trowbridge
 




    


    


      
Files


      

 
  
 
 
  src/index.ts
  
 
 
  
   

  
 		


    

    

   

  

 









 

  

   
    

     
      
      src/index.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...