Summary

Fix warnings about comments at the top of interfaces.

Review Request #13008 — Created May 4, 2023 and submitted May 5, 2023, 2:47 p.m.

Information

Owner

david

Repository

beanbag-eslint-plugin

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

The @typescript-eslint/eslint-plugin plugin recently gained a fix for
the spurious lines-around-comments warnings at the tops of interfaces
and other typescript-specific blocks. This change updates our plugin to
depend on that, and adds the new configuration to enable them.

Testing Done

Set up with a build of this and saw that I was no longer getting
warnings about comments that were the first line of an interface.

Commits

Summary	ID
Fix warnings about comments at the top of interfaces. The `@typescript-eslint/eslint-plugin` plugin recently gained a fix for the spurious lines-around-comments warnings at the tops of interfaces and other typescript-specific blocks. This change updates our plugin to depend on that, and adds the new configuration to enable them. Testing Done: Set up with a build of this and saw that I was no longer getting warnings about comments that were the first line of an interface.	158b23056031b212f19c57e2bb12e92b78befc0b

Summary

Fix warnings about comments at the top of interfaces.

The `@typescript-eslint/eslint-plugin` plugin recently gained a fix for the spurious lines-around-comments warnings at the tops of interfaces and other typescript-specific blocks. This change updates our plugin to depend on that, and adds the new configuration to enable them. Testing Done: Set up with a build of this and saw that I was no longer getting warnings about comments that were the first line of an interface.

158b23056031b212f19c57e2bb12e92b78befc0b

Issues

Description	From	Last Updated
Let's keep all these in alphabetical order.	chipx86	May 5, 2023, 1:48 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Forgot to commit part of this.

Commits:

	Summary	ID
	Fix warnings about comments at the top of interfaces. The `@typescript-eslint/eslint-plugin` plugin recently gained a fix for the spurious lines-around-comments warnings at the tops of interfaces and other typescript-specific blocks. This change updates our plugin to depend on that, and adds the new configuration to enable them. Testing Done: Set up with a build of this and saw that I was no longer getting warnings about comments that were the first line of an interface.	8a8899bd7dd3f24eb0661dca79d161fe5f31301c
	Fix warnings about comments at the top of interfaces. The `@typescript-eslint/eslint-plugin` plugin recently gained a fix for the spurious lines-around-comments warnings at the tops of interfaces and other typescript-specific blocks. This change updates our plugin to depend on that, and adds the new configuration to enable them. Testing Done: Set up with a build of this and saw that I was no longer getting warnings about comments that were the first line of an interface.	6b2df58ef2eede23248efe13f3337d80cfaf5fd6

Diff:

Revision 2 (+596 -50)

Show changes

	package.json
	package-lock.json
	src/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

```
Yesssssss....
```

src/index.ts (Diff revision 2)

Show all issues

Let's keep all these in alphabetical order.

Commits:

	Summary	ID
	Fix warnings about comments at the top of interfaces. The `@typescript-eslint/eslint-plugin` plugin recently gained a fix for the spurious lines-around-comments warnings at the tops of interfaces and other typescript-specific blocks. This change updates our plugin to depend on that, and adds the new configuration to enable them. Testing Done: Set up with a build of this and saw that I was no longer getting warnings about comments that were the first line of an interface.	6b2df58ef2eede23248efe13f3337d80cfaf5fd6
	Fix warnings about comments at the top of interfaces. The `@typescript-eslint/eslint-plugin` plugin recently gained a fix for the spurious lines-around-comments warnings at the tops of interfaces and other typescript-specific blocks. This change updates our plugin to depend on that, and adds the new configuration to enable them. Testing Done: Set up with a build of this and saw that I was no longer getting warnings about comments that were the first line of an interface.	158b23056031b212f19c57e2bb12e92b78befc0b

Diff:

Revision 3 (+596 -50)

Show changes

	package.json
	package-lock.json
	src/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (0392d5c)