Summary

Port API serializer methods over to TypeScript.

Review Request #13007 — Created May 4, 2023 and submitted May 17, 2023, 9:24 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the serializer methods to TypeScript.

Testing Done

Ran js-tests.

Commits

Summary	ID
Port API serializer methods over to TypeScript. This change ports the serializer methods to TypeScript. Testing Done: Ran js-tests.	7ae8a9e9eec4eee8221c0d0efcd0e52088df7294

Issues

Description	From	Last Updated
We should add a typing alias for these mappings (mybe even the serialize/deserializer function types themselves), so subclasses can reference …	chipx86	May 5, 2023, 3:43 p.m.
While here, can we add parens to make the order of logic explicit?	chipx86	May 5, 2023, 3:33 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/baseResource.ts (Diff revision 1)

The issue has been resolved. Show all issues

We should add a typing alias for these mappings (mybe even the serialize/deserializer function types themselves), so subclasses can reference them more easily.

reviewboard/static/rb/js/common/resources/utils/serializers.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
While here, can we add parens to make the order of logic explicit?
```
1. david May 5, 2023, 3:43 p.m.
  Gonna change this to if/else

Commits:

	Summary	ID
	Port API serializer methods over to TypeScript. This change ports the serializer methods to TypeScript. Testing Done: Ran js-tests.	1681e57f3335b5aaa55be3e331061fbfc6582e9e
	Port API serializer methods over to TypeScript. This change ports the serializer methods to TypeScript. Testing Done: Ran js-tests.	732f63d9e6943415ce87299d945ef3e484f6c12b

Diff:

Revision 2 (+242 -54)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseResource.ts
	reviewboard/static/rb/js/common/resources/utils/serializers.ts
	reviewboard/static/rb/js/resources/utils/serializers.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Mistakenly removed default initializers.

Commits:

	Summary	ID
	Port API serializer methods over to TypeScript. This change ports the serializer methods to TypeScript. Testing Done: Ran js-tests.	732f63d9e6943415ce87299d945ef3e484f6c12b
	Port API serializer methods over to TypeScript. This change ports the serializer methods to TypeScript. Testing Done: Ran js-tests.	7ae8a9e9eec4eee8221c0d0efcd0e52088df7294

Diff:

Revision 3 (+242 -54)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseResource.ts
	reviewboard/static/rb/js/common/resources/utils/serializers.ts
	reviewboard/static/rb/js/resources/utils/serializers.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (4e97557)