flake8
passed.
JSHint
passed.
Review Request #13007 — Created May 4, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
This change ports the serializer methods to TypeScript.
Ran js-tests.
reviewboard/static/rb/js/common/resources/models/baseResource.ts (Diff revision 1) |
---|
We should add a typing alias for these mappings (mybe even the serialize/deserializer function types themselves), so subclasses can reference them more easily.
reviewboard/static/rb/js/common/resources/utils/serializers.ts (Diff revision 1) |
---|
While here, can we add parens to make the order of logic explicit?
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+242 -54) |
Mistakenly removed default initializers.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+242 -54) |