• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Convert BaseCollection and ResourceCollection to spina.
    
 
    

    



 
    
 
    

  Review Request #13004
  —
  Created May 3, 2023 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-6.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    This change ports our basic collection types over to spina and
    
TypeScript.
    
 
    

    





  

    
 
 
    
  
    Ran js-tests.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Convert BaseCollection and ResourceCollection to spina.
      
    This change ports our basic collection types over to spina and
TypeScript.

Testing Done:
Ran js-tests.
    
     
    

        		
    5519b2c6fe5d456dd709389e487dd55d78c4faf3

   
    


      
 
    

    
    
 
    

    






 





    
 
 
 
    
  
    
   
    
    
    
     
    
    
    
      
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
    
    
   
    
   
    
    
     
    
      Description
      From
      Last Updated
     
    
        
    



     
    
      
       
       
    > on the next line.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    This is missing a docstring.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Alphabetical order.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Missing a docstring.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Elsewhere for wrapping, I've been putting extends on the next line. I feel it helps with readability a bit.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Alphabetical order.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    > on the next line.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Can we make this an interface, for easier reference by subclasses?
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Should use unknown where possible.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    As in other changes, ideally unit tests should just import the necessary modules themselves.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    

        
   
    
  
    
 
    

    




 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/collections/baseCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      > on the next line.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 






    3. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      This is missing a docstring.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 






    4. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Alphabetical order.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      5. 






    5. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Missing a docstring.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      6. 






    6. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Elsewhere for wrapping, I've been putting extends on the next line. I feel it helps with readability a bit.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      7. 






    7. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Alphabetical order.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      8. 






    8. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      > on the next line.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      9. 






    9. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Can we make this an interface, for easier reference by subclasses?
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      10. 






    10. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Should use unknown where possible.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      11. 






    11. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      As in other changes, ideally unit tests should just import the necessary modules themselves.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      12. 




    12. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      13. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-6.x (f10129f)