Convert BaseCollection and ResourceCollection to spina.

Review Request #13004 — Created May 3, 2023 and submitted

david
Review Board
release-6.x
reviewboard

This change ports our basic collection types over to spina and
TypeScript.

Ran js-tests.

Summary
Convert BaseCollection and ResourceCollection to spina.
Description From Last Updated

> on the next line.

chipx86chipx86

This is missing a docstring.

chipx86chipx86

Alphabetical order.

chipx86chipx86

Missing a docstring.

chipx86chipx86

Elsewhere for wrapping, I've been putting extends on the next line. I feel it helps with readability a bit.

chipx86chipx86

Alphabetical order.

chipx86chipx86

> on the next line.

chipx86chipx86

Can we make this an interface, for easier reference by subclasses?

chipx86chipx86

Should use unknown where possible.

chipx86chipx86

As in other changes, ideally unit tests should just import the necessary modules themselves.

chipx86chipx86
chipx86
  1. 
      
  2. Alphabetical order.

  3. Elsewhere for wrapping, I've been putting extends on the next line. I feel it helps with readability a bit.

  4. reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Alphabetical order.

  5. Can we make this an interface, for easier reference by subclasses?

  6. Should use unknown where possible.

  7. As in other changes, ideally unit tests should just import the necessary modules themselves.

  8. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (f10129f)
Loading...