Convert BaseCollection and ResourceCollection to spina.
Review Request #13004 — Created May 3, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
This change ports our basic collection types over to spina and
TypeScript.
Ran js-tests.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
> on the next line. |
|
|
This is missing a docstring. |
|
|
Alphabetical order. |
|
|
Missing a docstring. |
|
|
Elsewhere for wrapping, I've been putting extends on the next line. I feel it helps with readability a bit. |
|
|
Alphabetical order. |
|
|
> on the next line. |
|
|
Can we make this an interface, for easier reference by subclasses? |
|
|
Should use unknown where possible. |
|
|
As in other changes, ideally unit tests should just import the necessary modules themselves. |
|
-
-
-
-
-
-
Elsewhere for wrapping, I've been putting
extends
on the next line. I feel it helps with readability a bit. -
-
-
-
-
reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts (Diff revision 1) As in other changes, ideally unit tests should just import the necessary modules themselves.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+568 -324) |