Summary

Convert BaseCollection and ResourceCollection to spina.

Review Request #13004 — Created May 3, 2023 and submitted May 17, 2023, 9:24 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

People

Description

This change ports our basic collection types over to spina and
TypeScript.

Testing Done

Ran js-tests.

Commits

Summary	ID
Convert BaseCollection and ResourceCollection to spina. This change ports our basic collection types over to spina and TypeScript. Testing Done: Ran js-tests.	5519b2c6fe5d456dd709389e487dd55d78c4faf3

Issues

Description	From	Last Updated
> on the next line.	chipx86	May 5, 2023, 3:10 p.m.
This is missing a docstring.	chipx86	May 5, 2023, 3:11 p.m.
Alphabetical order.	chipx86	May 5, 2023, 3:11 p.m.
Missing a docstring.	chipx86	May 5, 2023, 3:11 p.m.
Elsewhere for wrapping, I've been putting extends on the next line. I feel it helps with readability a bit.	chipx86	May 5, 2023, 3:11 p.m.
Alphabetical order.	chipx86	May 5, 2023, 3:12 p.m.
> on the next line.	chipx86	May 5, 2023, 3:12 p.m.
Can we make this an interface, for easier reference by subclasses?	chipx86	May 5, 2023, 3:15 p.m.
Should use unknown where possible.	chipx86	May 5, 2023, 3:12 p.m.
As in other changes, ideally unit tests should just import the necessary modules themselves.	chipx86	May 5, 2023, 3:13 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/collections/baseCollection.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
> on the next line.
```
reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This is missing a docstring.
```

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)

The issue has been resolved. Show all issues

Alphabetical order.

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing a docstring.
```

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)

The issue has been resolved. Show all issues

Elsewhere for wrapping, I've been putting extends on the next line. I feel it helps with readability a bit.

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)

The issue has been resolved. Show all issues

Alphabetical order.

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
> on the next line.
```

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)

The issue has been resolved. Show all issues

Can we make this an interface, for easier reference by subclasses?

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)

The issue has been resolved. Show all issues

Should use unknown where possible.

reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts (Diff revision 1)

The issue has been resolved. Show all issues

As in other changes, ideally unit tests should just import the necessary modules themselves.

Commits:

	Summary	ID
	Convert BaseCollection and ResourceCollection to spina. This change ports our basic collection types over to spina and TypeScript. Testing Done: Ran js-tests.	4e8eeae8eb9a9ae223ff903918e7491ee840d81d
	Convert BaseCollection and ResourceCollection to spina. This change ports our basic collection types over to spina and TypeScript. Testing Done: Ran js-tests.	5519b2c6fe5d456dd709389e487dd55d78c4faf3

Diff:

Revision 2 (+568 -324)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/index.ts
	reviewboard/static/rb/js/collections/baseCollection.es6.js
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/resources/collections/resourceCollection.es6.js
	reviewboard/static/rb/js/common/resources/collections/tests/index.ts
	reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.es6.js
	reviewboard/static/rb/js/common/resources/models/baseResource.ts
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (f10129f)