Summary

Port BaseResource (and extra data helpers) to spina.

Review Request #13003 — Created May 3, 2023 and submitted May 17, 2023, 9:24 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the BaseResource class to spina and TypeScript. Along

with it comes the ExtraData model and ExtraDataMixin.

Testing Done


Ran js-tests.
Went through and tested various bits of functionality on the site.

Commits

Summary	ID
Port BaseResource (and extra data helpers) to spina. This change ports the `BaseResource` class to spina and TypeScript. Along with it comes the `ExtraData` model and `ExtraDataMixin`. Testing Done: - Ran js-tests. - Went through and tested various bits of functionality on the site.	65dd33ca309bb545121bdb593c6a87dbb58fa3c7

Issues

Description	From	Last Updated
Probably should be unknown instead of any. (any is a last-resort with no type checking, but unknown has some basic …	chipx86	May 5, 2023, 3:03 p.m.
Should probably be unknown.	chipx86	May 5, 2023, 3:03 p.m.
Here, too.	chipx86	May 5, 2023, 3:03 p.m.
Probably should use unknown, unless there are problems. Same below.	chipx86	May 5, 2023, 3:03 p.m.
This feels strangely wrapped. Can we pull this out into a variable and then check that result?	chipx86	May 5, 2023, 3:04 p.m.
We can document options as being SaveWithFilesOptions and remove the Option Args now. Same with others.	chipx86	May 5, 2023, 3:09 p.m.
Same comment as on another change: If we have unit tests include things relatively, we can more easily test without …	chipx86	May 5, 2023, 3:07 p.m.

flake8 passed.

JSHint passed.

```
Very nice! Glad we're getting this in.
```

reviewboard/static/rb/js/common/models/extraDataMixin.ts (Diff revision 1)

Show all issues

Probably should be unknown instead of any. (any is a last-resort with no type checking, but unknown has some basic type checking).

reviewboard/static/rb/js/common/models/extraDataMixin.ts (Diff revision 1)
Show all issues
```
Should probably be unknown.
```
reviewboard/static/rb/js/common/models/extraDataMixin.ts (Diff revision 1)
Show all issues
```
Here, too.
```
reviewboard/static/rb/js/common/resources/models/baseResource.ts (Diff revision 1)
Show all issues
```
Probably should use unknown, unless there are problems.
Same below.
```

reviewboard/static/rb/js/common/resources/models/baseResource.ts (Diff revision 1)

Show all issues

This feels strangely wrapped. Can we pull this out into a variable and then check that result?

reviewboard/static/rb/js/common/resources/models/baseResource.ts (Diff revision 1)

Show all issues

We can document options as being SaveWithFilesOptions and remove the Option Args now. Same with others.

reviewboard/static/rb/js/reviews/models/tests/commentEditorModelTests.ts (Diff revision 1)

Show all issues

Same comment as on another change: If we have unit tests include things relatively, we can more easily test without needing things to live in RB (which will happen during compilation), and we can eventually even treeshake the tests.

Commits:

	Summary	ID
	Port BaseResource (and extra data helpers) to spina. This change ports the `BaseResource` class to spina and TypeScript. Along with it comes the `ExtraData` model and `ExtraDataMixin`. Testing Done: - Ran js-tests. - Went through and tested various bits of functionality on the site.	f596bc50b057b5984481561766da38c686a7673b
	Port BaseResource (and extra data helpers) to spina. This change ports the `BaseResource` class to spina and TypeScript. Along with it comes the `ExtraData` model and `ExtraDataMixin`. Testing Done: - Ran js-tests. - Went through and tested various bits of functionality on the site.	65dd33ca309bb545121bdb593c6a87dbb58fa3c7

Diff:

Revision 2 (+988 -512)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/index.ts
	reviewboard/static/rb/js/models/extraDataModel.es6.js
	reviewboard/static/rb/js/models/extraDataMixin.es6.js
	reviewboard/static/rb/js/common/models/tests/extraDataTests.ts
	reviewboard/static/rb/js/common/models/tests/index.ts
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (d8a2f4c)