Fix bugs in SSO autologin.

 






 

 


  Review Request #12999
  —
  Created May 1, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The port of the SSO autologin to 5.0.x had a couple problems. First, we

were using a bad reference for the ItemLookupError check. Second,

django had deprecated is_safe_url and inadventantly changed the way it

works in the process. This change updates the code to use its successor

in the correct way.

 








  


 
 

  
Enabled SSO auto-login and was able to successfully go through the login

flow.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Fix bugs in SSO autologin.
     
The port of the SSO autologin to 5.0.x had a couple problems. First, we
were using a bad reference for the `ItemLookupError` check. Second,
django had deprecated `is_safe_url` and inadventantly changed the way it
works in the process. This change updates the code to use its successor
in the correct way.

Testing Done:
Enabled SSO auto-login and was able to successfully go through the login
flow.

    

   
  		
  fd49c284f966b580921503cccc169bad3c523880
  David Trowbridge
 


 
  
 
 
  
   
    

     Fix bugs in SSO autologin.
     
The port of the SSO autologin to 5.0.x had a couple problems. First, we
were using a bad reference for the `ItemLookupError` check. Second,
django had deprecated `is_safe_url` and inadventantly changed the way it
works in the process. This change updates the code to use its successor
in the correct way.

Testing Done:
Enabled SSO auto-login and was able to successfully go through the login
flow.

    

   
  		
  ce83c80ecfcdda99284146e284c080e48219c735
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/accounts/views.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/extensions/hooks.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...