flake8
failed.
JSHint
passed.
flake8
-
reviewboard/accounts/views.py (Diff revision 1) Show all issues
Review Request #12999 — Created May 1, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-5.0.x | |
Reviewers | |
reviewboard | |
The port of the SSO autologin to 5.0.x had a couple problems. First, we
were using a bad reference for theItemLookupError
check. Second,
django had deprecatedis_safe_url
and inadventantly changed the way it
works in the process. This change updates the code to use its successor
in the correct way.
Enabled SSO auto-login and was able to successfully go through the login
flow.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+10 -6) |
Thanks for adding this, was gonna make a change for it later.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+34 -12) |