Summary

Fix bugs in SSO autologin.

Review Request #12999 — Created May 1, 2023 and submitted May 2, 2023, 9:18 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The port of the SSO autologin to 5.0.x had a couple problems. First, we
were using a bad reference for the ItemLookupError check. Second,
django had deprecated is_safe_url and inadventantly changed the way it
works in the process. This change updates the code to use its successor
in the correct way.

Testing Done

Enabled SSO auto-login and was able to successfully go through the login
flow.

Commits

Summary	ID
Fix bugs in SSO autologin. The port of the SSO autologin to 5.0.x had a couple problems. First, we were using a bad reference for the `ItemLookupError` check. Second, django had deprecated `is_safe_url` and inadventantly changed the way it works in the process. This change updates the code to use its successor in the correct way. Testing Done: Enabled SSO auto-login and was able to successfully go through the login flow.	ce83c80ecfcdda99284146e284c080e48219c735

Summary

Fix bugs in SSO autologin.

The port of the SSO autologin to 5.0.x had a couple problems. First, we were using a bad reference for the `ItemLookupError` check. Second, django had deprecated `is_safe_url` and inadventantly changed the way it works in the process. This change updates the code to use its successor in the correct way. Testing Done: Enabled SSO auto-login and was able to successfully go through the login flow.

ce83c80ecfcdda99284146e284c080e48219c735

Issues

Description	From	Last Updated
line too long (85 > 79 characters) Column: 80 Error code: E501	reviewbot	May 1, 2023, 3:43 p.m.
This needs to be changed to ItemLookupError too.	maubin	May 2, 2023, 8:21 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/views.py (Diff revision 1)

Show all issues

line too long (85 > 79 characters)

Column: 80
Error code: E501

Commits:

	Summary	ID
	Fix bugs in SSO autologin. The port of the SSO autologin to 5.0.x had a couple problems. First, we were using a bad reference for the `ItemLookupError` check. Second, django had deprecated `is_safe_url` and inadventantly changed the way it works in the process. This change updates the code to use its successor in the correct way. Testing Done: Enabled SSO auto-login and was able to successfully go through the login flow.	f4d64d92f55576c9e9a2bd48b99171cf3b6bf4b7
	Fix bugs in SSO autologin. The port of the SSO autologin to 5.0.x had a couple problems. First, we were using a bad reference for the `ItemLookupError` check. Second, django had deprecated `is_safe_url` and inadventantly changed the way it works in the process. This change updates the code to use its successor in the correct way. Testing Done: Enabled SSO auto-login and was able to successfully go through the login flow.	fd49c284f966b580921503cccc169bad3c523880

Diff:

Revision 2 (+10 -6)

Show changes

reviewboard/accounts/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Thanks for adding this, was gonna make a change for it later.

reviewboard/accounts/views.py (Diff revision 2)
Show all issues
```
This needs to be changed to ItemLookupError too.
```

Commits:

	Summary	ID
	Fix bugs in SSO autologin. The port of the SSO autologin to 5.0.x had a couple problems. First, we were using a bad reference for the `ItemLookupError` check. Second, django had deprecated `is_safe_url` and inadventantly changed the way it works in the process. This change updates the code to use its successor in the correct way. Testing Done: Enabled SSO auto-login and was able to successfully go through the login flow.	fd49c284f966b580921503cccc169bad3c523880
	Fix bugs in SSO autologin. The port of the SSO autologin to 5.0.x had a couple problems. First, we were using a bad reference for the `ItemLookupError` check. Second, django had deprecated `is_safe_url` and inadventantly changed the way it works in the process. This change updates the code to use its successor in the correct way. Testing Done: Enabled SSO auto-login and was able to successfully go through the login flow.	ce83c80ecfcdda99284146e284c080e48219c735

Diff:

Revision 3 (+34 -12)

Show changes

	reviewboard/accounts/views.py
	reviewboard/extensions/hooks.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (1ef483e)