Ease restrictions on installing into non-empty site directories.

Review Request #12997 — Created April 30, 2023 and updated — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

rb-site install will now permit installing into a site directory that
contains only a venv folder. This is to enable deployments where a
virtual environment is first set up in the destination sitedir, and then
the installed rb-site is used to populate the sitedir.

There's also a --allow-non-empty-sitedir option for advanced use,
which bypasses the empty sitedir check.

Tested installing into a populated sitedir. It gave me the expected error.

Tested installing into a new location. Installation was allowed.

Tested installing into a directory containing just a venv directory.
Installation was allowed.

Tested installing into an empty directory. Installation was allowed.

Tested installing into a populated sitedir and using
--allow-non-empty-sitedir. Installation was allowed.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Ease restrictions on installing into non-empty site directories.
`rb-site install` will now permit installing into a site directory that contains only a `venv` folder. This is to enable deployments where a virtual environment is first set up in the destination sitedir, and then the installed `rb-site` is used to populate the sitedir. There's also a `--allow-non-empty-sitedir` option for advanced use, which bypasses the empty sitedir check.
3fc1ba7366fdcc779a7180267883d9c1341f8d83 Christian Hammond
reviewboard/cmdline/rbsite.py
Loading...