Add type hints for the rest of djblets.integrations.

 






 

 


  Review Request #12995
  —
  Created April 27, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
This adds type hints for all remaining modules and tests in

djblets.integrations, helping people develop or work with

integrations.


A couple minor issues were caught by fixing up types, but had no impact

on consumers:


    

  • 

    IntegrationConfigForm could crash if manually calling
    
get_key_value() or set_key_value() if creating a new
    
  configuration.
    

    • 

  • 

    Unit test setup for IntegrationConfig's manager wasn't correct. We
    
  were overriding a classmethod with a standard member function.
    

    • 



With this change, djblets.integrations is now fully typed.

 








  


 
 

  
Unit tests, mypy, and pyright pass.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add type hints for the rest of djblets.integrations.
     
This adds type hints for all remaining modules and tests in
`djblets.integrations`, helping people develop or work with
integrations.

A couple minor issues were caught by fixing up types, but had no impact
on consumers:

* `IntegrationConfigForm` could crash if manually calling
  `get_key_value()` or `set_key_value()` if creating a new
  configuration.

* Unit test setup for `IntegrationConfig`'s manager wasn't correct. We
  were overriding a classmethod with a standard member function.

With this change, `djblets.integrations` is now fully typed.

    

   
  		
  a5aadca1388d0c86473a72a422ce65a3a1c75886
  Christian Hammond
 


 
  
 
 
  
   
    

     Add type hints for the rest of djblets.integrations.
     
This adds type hints for all remaining modules and tests in
`djblets.integrations`, helping people develop or work with
integrations.

A couple minor issues were caught by fixing up types, but had no impact
on consumers:

* `IntegrationConfigForm` could crash if manually calling
  `get_key_value()` or `set_key_value()` if creating a new
  configuration.

* Unit test setup for `IntegrationConfig`'s manager wasn't correct. We
  were overriding a classmethod with a standard member function.

With this change, `djblets.integrations` is now fully typed.

    

   
  		
  f383df88eada847fd4771cdea4b3cd494e3bd3c4
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/integrations/models.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...