Summary

Add type hints for the rest of djblets.integrations.

Review Request #12995 — Created April 27, 2023 and submitted June 15, 2023, 4:38 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This adds type hints for all remaining modules and tests in
djblets.integrations, helping people develop or work with
integrations.

A couple minor issues were caught by fixing up types, but had no impact
on consumers:

IntegrationConfigForm could crash if manually calling
get_key_value() or set_key_value() if creating a new
configuration.
Unit test setup for IntegrationConfig's manager wasn't correct. We
were overriding a classmethod with a standard member function.

With this change, djblets.integrations is now fully typed.

Testing Done

Unit tests, mypy, and pyright pass.

Commits

Summary	ID
Add type hints for the rest of djblets.integrations. This adds type hints for all remaining modules and tests in `djblets.integrations`, helping people develop or work with integrations. A couple minor issues were caught by fixing up types, but had no impact on consumers: * `IntegrationConfigForm` could crash if manually calling `get_key_value()` or `set_key_value()` if creating a new configuration. * Unit test setup for `IntegrationConfig`'s manager wasn't correct. We were overriding a classmethod with a standard member function. With this change, `djblets.integrations` is now fully typed.	f383df88eada847fd4771cdea4b3cd494e3bd3c4

Summary

Add type hints for the rest of djblets.integrations.

This adds type hints for all remaining modules and tests in `djblets.integrations`, helping people develop or work with integrations. A couple minor issues were caught by fixing up types, but had no impact on consumers: * `IntegrationConfigForm` could crash if manually calling `get_key_value()` or `set_key_value()` if creating a new configuration. * Unit test setup for `IntegrationConfig`'s manager wasn't correct. We were overriding a classmethod with a standard member function. With this change, `djblets.integrations` is now fully typed.

f383df88eada847fd4771cdea4b3cd494e3bd3c4

Issues

Description	From	Last Updated
Should we be using object or Any?	david	June 1, 2023, 2:38 p.m.
Same question here.	david	June 1, 2023, 2:38 p.m.

flake8 passed.

JSHint passed.

djblets/integrations/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should we be using object or Any?
```
djblets/integrations/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same question here.
```

Change Summary:

Switched from object to Any for setting values.

Commits:

	Summary	ID
	Add type hints for the rest of djblets.integrations. This adds type hints for all remaining modules and tests in `djblets.integrations`, helping people develop or work with integrations. A couple minor issues were caught by fixing up types, but had no impact on consumers: * `IntegrationConfigForm` could crash if manually calling `get_key_value()` or `set_key_value()` if creating a new configuration. * Unit test setup for `IntegrationConfig`'s manager wasn't correct. We were overriding a classmethod with a standard member function. With this change, `djblets.integrations` is now fully typed.	a5aadca1388d0c86473a72a422ce65a3a1c75886
	Add type hints for the rest of djblets.integrations. This adds type hints for all remaining modules and tests in `djblets.integrations`, helping people develop or work with integrations. A couple minor issues were caught by fixing up types, but had no impact on consumers: * `IntegrationConfigForm` could crash if manually calling `get_key_value()` or `set_key_value()` if creating a new configuration. * Unit test setup for `IntegrationConfig`'s manager wasn't correct. We were overriding a classmethod with a standard member function. With this change, `djblets.integrations` is now fully typed.	f383df88eada847fd4771cdea4b3cd494e3bd3c4

Diff:

Revision 2 (+610 -240)

Show changes

	djblets/integrations/forms.py
	djblets/integrations/hooks.py
	djblets/integrations/middleware.py
	djblets/integrations/mixins.py
	djblets/integrations/models.py
	djblets/integrations/views.py
	djblets/integrations/tests/models.py
	djblets/integrations/tests/test_forms.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (2d58f85)