Add type hints for the rest of djblets.integrations.
Review Request #12995 — Created April 27, 2023 and submitted
This adds type hints for all remaining modules and tests in
djblets.integrations
, helping people develop or work with
integrations.A couple minor issues were caught by fixing up types, but had no impact
on consumers:
-
IntegrationConfigForm
could crash if manually calling
get_key_value()
orset_key_value()
if creating a new
configuration. -
Unit test setup for
IntegrationConfig
's manager wasn't correct. We
were overriding a classmethod with a standard member function.
With this change, djblets.integrations
is now fully typed.
Unit tests, mypy, and pyright pass.
- Change Summary:
-
Switched from
object
toAny
for setting values. - Commits:
-
Summary ID a5aadca1388d0c86473a72a422ce65a3a1c75886 f383df88eada847fd4771cdea4b3cd494e3bd3c4 - Diff:
-
Revision 2 (+610 -240)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.