Cap the maximum number of lines for a comment to 10.

Review Request #12986 — Created April 24, 2023 and submitted

Information

ReviewBot
release-3.x

Reviewers

Some tools include a pretty wide range of lines when reporting a
comment. PMD, for instance, will list the entire line range for a
function or a comment, which is excessive and not particularly useful.

We now cap comments to 10 lines. When capped, the total line range is
shown in the comment, giving people enough context to see the entire set
of lines for the reported issue.

Unit tests pass.

Summary ID
Cap the maximum number of lines for a comment to 10.
Some tools include a pretty wide range of lines when reporting a comment. PMD, for instance, will list the entire line range for a function or a comment, which is excessive and not particularly useful. We now cap comments to 10 lines. When capped, the total line range is shown in the comment, giving people enough context to see the entire set of lines for the reported issue.
0425a7e51e76f9ba5f0e83e437c6c188d780b9db
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (9efa0de)
Loading...