Summary

Fix crashes when failing to load hosting services during repo config.

Review Request #12983 — Created April 24, 2023 and submitted Oct. 1, 2023, 10:59 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The repository list now catches this case when trying to render the
hosting service name, and falls back on showing the stored ID instead,
along with a "(missing support)" suffix.

The repository configuration form catches this in a couple of spots as
well, allowing the form to load even if a hosting service can't.

There are still problems that can occur with rendering information for
SCMTools, due to the fact that they can be loaded from entrypoints, but
those are beyond the scope of this change.

Testing Done

Tested loading my repository list and config form while Power Pack was
uninstalled. Saw that both pages successfully loaded, and that the
affected repositories had the new suffix.

Commits

Summary	ID
Fix crashes when failing to load hosting services during repo config. Repositories backed by hosting services could crash both the repository list in the administration UI and the repository configuration form. Assumptions were being made about whether a `HostingService` could be loaded, and this meant we weren't catching exceptions. The repository list now catches this case when trying to render the hosting service name, and falls back on showing the stored ID instead, along with a "(missing support)" suffix. The repository configuration form catches this in a couple of spots as well, allowing the form to load even if a hosting service can't. There are still problems that can occur with rendering information for SCMTools, due to the fact that they can be loaded from entrypoints, but those are beyond the scope of this change.	0bad98d2e2f44235a65f2a075730165869a1cf49

Summary

Fix crashes when failing to load hosting services during repo config.

Repositories backed by hosting services could crash both the repository list in the administration UI and the repository configuration form. Assumptions were being made about whether a `HostingService` could be loaded, and this meant we weren't catching exceptions. The repository list now catches this case when trying to render the hosting service name, and falls back on showing the stored ID instead, along with a "(missing support)" suffix. The repository configuration form catches this in a couple of spots as well, allowing the form to load even if a hosting service can't. There are still problems that can occur with rendering information for SCMTools, due to the fact that they can be loaded from entrypoints, but those are beyond the scope of this change.

0bad98d2e2f44235a65f2a075730165869a1cf49

Issues

Description	From	Last Updated
'typing.TYPE_CHECKING' imported but unused Column: 1 Error code: F401	reviewbot	April 24, 2023, 5:26 p.m.
undefined name 'Type' Column: 43 Error code: F821	reviewbot	April 24, 2023, 5:26 p.m.
undefined name 'HostingService' Column: 48 Error code: F821	reviewbot	April 24, 2023, 5:26 p.m.
undefined name 'HostingService' Column: 39 Error code: F821	reviewbot	April 24, 2023, 5:26 p.m.
Since you're here, mind adding a module docstring?	david	May 19, 2023, 5:38 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.TYPE_CHECKING' imported but unused

Column: 1
Error code: F401
```
reviewboard/scmtools/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'Type'

Column: 43
Error code: F821
```
reviewboard/scmtools/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'HostingService'

Column: 48
Error code: F821
```
reviewboard/scmtools/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
undefined name 'HostingService'

Column: 39
Error code: F821
```

Change Summary:

Fixed missing imports from a bad git add -p.

Commits:

	Summary	ID
	Fix crashes when failing to load hosting services during repo config. Repositories backed by hosting services could crash both the repository list in the administration UI and the repository configuration form. Assumptions were being made about whether a `HostingService` could be loaded, and this meant we weren't catching exceptions. The repository list now catches this case when trying to render the hosting service name, and falls back on showing the stored ID instead, along with a "(missing support)" suffix. The repository configuration form catches this in a couple of spots as well, allowing the form to load even if a hosting service can't. There are still problems that can occur with rendering information for SCMTools, due to the fact that they can be loaded from entrypoints, but those are beyond the scope of this change.	0db02fb45c8be6ac35c0485102c5e6231d14760d
	Fix crashes when failing to load hosting services during repo config. Repositories backed by hosting services could crash both the repository list in the administration UI and the repository configuration form. Assumptions were being made about whether a `HostingService` could be loaded, and this meant we weren't catching exceptions. The repository list now catches this case when trying to render the hosting service name, and falls back on showing the stored ID instead, along with a "(missing support)" suffix. The repository configuration form catches this in a couple of spots as well, allowing the form to load even if a hosting service can't. There are still problems that can occur with rendering information for SCMTools, due to the fact that they can be loaded from entrypoints, but those are beyond the scope of this change.	a4dc0413c26cd225793af132e84563393b6bdcda

Diff:

Revision 2 (+172 -36)

Show changes

	reviewboard/hostingsvcs/models.py
	reviewboard/scmtools/admin.py
	reviewboard/scmtools/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Since you're here, mind adding a module docstring?
```

Change Summary:

Added a module docstring.

Commits:

	Summary	ID
	Fix crashes when failing to load hosting services during repo config. Repositories backed by hosting services could crash both the repository list in the administration UI and the repository configuration form. Assumptions were being made about whether a `HostingService` could be loaded, and this meant we weren't catching exceptions. The repository list now catches this case when trying to render the hosting service name, and falls back on showing the stored ID instead, along with a "(missing support)" suffix. The repository configuration form catches this in a couple of spots as well, allowing the form to load even if a hosting service can't. There are still problems that can occur with rendering information for SCMTools, due to the fact that they can be loaded from entrypoints, but those are beyond the scope of this change.	a4dc0413c26cd225793af132e84563393b6bdcda
	Fix crashes when failing to load hosting services during repo config. Repositories backed by hosting services could crash both the repository list in the administration UI and the repository configuration form. Assumptions were being made about whether a `HostingService` could be loaded, and this meant we weren't catching exceptions. The repository list now catches this case when trying to render the hosting service name, and falls back on showing the stored ID instead, along with a "(missing support)" suffix. The repository configuration form catches this in a couple of spots as well, allowing the form to load even if a hosting service can't. There are still problems that can occur with rendering information for SCMTools, due to the fact that they can be loaded from entrypoints, but those are beyond the scope of this change.	0bad98d2e2f44235a65f2a075730165869a1cf49

Diff:

Revision 3 (+180 -36)

Show changes

	reviewboard/hostingsvcs/models.py
	reviewboard/scmtools/admin.py
	reviewboard/scmtools/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (78dd840)