Summary

Add a P4 trigger script and P4V configurations for RBTools.

Review Request #12977 — Created April 21, 2023 and submitted May 8, 2023, 12:19 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The new p4-trigger-script interfaces with RBTools and Perforce to
enable administrators to integrate their Perforce servers with Review
Board. It offers options for requiring submitted changes to have review
requests, to require those review requests to be approved, and to
auto-close review requests.

There's also a new set of P4V configurations, which replace the ancient
P4Win configuration (which still mentioned post-review). These are
available for Windows, macOS, and Linux, and allow users to post/update
review requests right from P4V.

Testing Done

Tested all the options in the trigger script locally.

Tested P4V on macOS and on Windows locally. A customer tested it on
Windows as well.

Verified the contents rendered correctly in the README.

Commits

Summary	ID
Add a P4 trigger script and P4V configurations for RBTools. The new `p4-trigger-script` interfaces with RBTools and Perforce to enable administrators to integrate their Perforce servers with Review Board. It offers options for requiring submitted changes to have review requests, to require those review requests to be approved, and to auto-close review requests. There's also a new set of P4V configurations, which replace the ancient P4Win configuration (which still mentioned post-review). These are available for Windows, macOS, and Linux, and allow users to post/update review requests right from P4V.	4fe7c36982e4377d5a2ec7a04d6fdee3061a9c68

Summary

Add a P4 trigger script and P4V configurations for RBTools.

The new `p4-trigger-script` interfaces with RBTools and Perforce to enable administrators to integrate their Perforce servers with Review Board. It offers options for requiring submitted changes to have review requests, to require those review requests to be approved, and to auto-close review requests. There's also a new set of P4V configurations, which replace the ancient P4Win configuration (which still mentioned post-review). These are available for Windows, macOS, and Linux, and allow users to post/update review requests right from P4V.

4fe7c36982e4377d5a2ec7a04d6fdee3061a9c68

Issues

Description	From	Last Updated
Should we tell them to talk to their admin rather than us?	david	April 23, 2023, 1:10 p.m.
This is worded a little bit awkwardly.	david	April 23, 2023, 1:13 p.m.

flake8 passed.

JSHint passed.

contrib/tools/p4-trigger-script (Diff revision 1)
The issue has been resolved. Show all issues
```
Should we tell them to talk to their admin rather than us?
```
contrib/tools/p4-trigger-script (Diff revision 1)
The issue has been resolved. Show all issues
```
This is worded a little bit awkwardly.
```

Change Summary:


Improved the wording in some of the output.
Removed some debug code for force-bailing on a submit.

Commits:

	Summary	ID
	Add a P4 trigger script and P4V configurations for RBTools. The new `p4-trigger-script` interfaces with RBTools and Perforce to enable administrators to integrate their Perforce servers with Review Board. It offers options for requiring submitted changes to have review requests, to require those review requests to be approved, and to auto-close review requests. There's also a new set of P4V configurations, which replace the ancient P4Win configuration (which still mentioned post-review). These are available for Windows, macOS, and Linux, and allow users to post/update review requests right from P4V.	bc6acd6159e29eaa991139f9d66d92cf54a571af
	Add a P4 trigger script and P4V configurations for RBTools. The new `p4-trigger-script` interfaces with RBTools and Perforce to enable administrators to integrate their Perforce servers with Review Board. It offers options for requiring submitted changes to have review requests, to require those review requests to be approved, and to auto-close review requests. There's also a new set of P4V configurations, which replace the ancient P4Win configuration (which still mentioned post-review). These are available for Windows, macOS, and Linux, and allow users to post/update review requests right from P4V.	4fe7c36982e4377d5a2ec7a04d6fdee3061a9c68

Diff:

Revision 2 (+506 -54)

Show changes

	contrib/P4Tool.txt
	contrib/README.P4Tool
	contrib/P4V/P4V-Mac-Linux-Tools-Import.xml
	contrib/P4V/P4V-Windows-RBTools-Install.xml
	contrib/P4V/README.md
	contrib/tools/p4-trigger-script

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (896f399)