Convert $.setVisible to $.toggle.
Review Request #12976 — Created April 21, 2023 and submitted — Latest diff uploaded
When we first wrote Review Board's JS codebase, jQuery forced you to
either use.show()or.hide(), and didn't have a way to easily show
based on a bool, so we wrote our own. Way back in jQuery 1.3, they added
this, but we never noticed. This change updates our codebase to use
$.toggle()instead.
Ran js-tests.
Diff Revision 1 (Latest)
Commits
Files
| reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js |
|---|
| reviewboard/static/rb/js/admin/repositoryform.es6.js |
|---|
| reviewboard/static/rb/js/admin/views/inlineFormGroupView.es6.js |
|---|
| reviewboard/static/rb/js/admin/views/webhookFormView.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/views/reviewView.es6.js |
|---|
| reviewboard/static/rb/js/reviews/views/commentDialogView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts |
|---|
| reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts |
|---|
| reviewboard/static/rb/js/ui/views/formView.es6.js |
|---|
| reviewboard/static/rb/js/ui/views/inlineEditorView.es6.js |
|---|
| reviewboard/static/rb/js/ui/views/textEditorView.es6.js |
|---|
| reviewboard/static/rb/js/views/textBasedReviewableView.es6.js |
|---|
| reviewboard/static/rb/js/views/uploadDiffView.es6.js |
|---|