Convert $.setVisible to $.toggle.

Review Request #12976 — Created April 21, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

When we first wrote Review Board's JS codebase, jQuery forced you to
either use .show() or .hide(), and didn't have a way to easily show
based on a bool, so we wrote our own. Way back in jQuery 1.3, they added
this, but we never noticed. This change updates our codebase to use
$.toggle() instead.

Ran js-tests.

Summary ID
Convert $.setVisible to $.toggle.
When we first wrote Review Board's JS codebase, jQuery forced you to either use `.show()` or `.hide()`, and didn't have a way to easily show based on a bool, so we wrote our own. Way back in jQuery 1.3, they added this, but we never noticed. This change updates our codebase to use `$.toggle()` instead. Testing Done: Ran js-tests.
1c7bcbca24361137436b52a1a74a1a4248aef8bb
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (35683ba)