Convert $.setVisible to $.toggle.

 






 

 


  Review Request #12975
  —
  Created April 21, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-4.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
When we first wrote Djblets's JS codebase, jQuery forced you to either

use .show() or .hide(), and didn't have a way to easily show based

on a bool, so we wrote our own. Way back in jQuery 1.3, they added this,

but we never noticed. This change updates our codebase to use

$.toggle() instead.

 








  


 
 

  
Ran js-tests.

 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert $.setVisible to $.toggle.
     
When we first wrote Djblets's JS codebase, jQuery forced you to either
use `.show()` or `.hide()`, and didn't have a way to easily show based
on a bool, so we wrote our own. Way back in jQuery 1.3, they added this,
but we never noticed. This change updates our codebase to use
`$.toggle()` instead.

Testing Done:
Ran js-tests.

    

   
  		
  4989bf44083a42e4b525547745c52e6d99d0d8b8
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/static/djblets/js/jquery.gravy.backboneUtils.js
     
    

   
  

 



 

  

   
    

     
      
      djblets/static/djblets/js/jquery.gravy.util.js
     
    

   
  

 



 

  

   
    

     
      
      djblets/static/djblets/js/forms/views/conditionSetView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...