Summary:

Convert $.setVisible to $.toggle.

Review Request #12975 — Created April 21, 2023 and submitted April 21, 2023, 4:09 p.m.

Information
Owner:	david
Repository:	Djblets
Branch:	release-4.x
Bugs:
Depends On:
Reviewers
Groups:	djblets
People:

Description

When we first wrote Djblets's JS codebase, jQuery forced you to either
use .show() or .hide(), and didn't have a way to easily show based
on a bool, so we wrote our own. Way back in jQuery 1.3, they added this,
but we never noticed. This change updates our codebase to use
$.toggle() instead.

Testing Done

Ran js-tests.

Commits

Summary
	Convert $.setVisible to $.toggle.

Screenshots

Issues

Description	From	Last Updated
Missing semicolon. Column: 37 Error code: W033	reviewbot	April 21, 2023, 2:09 p.m.

flake8 passed.

JSHint failed.

JSHint

djblets/static/djblets/js/jquery.gravy.util.js (Diff revision 1)
Show all issues
```
Missing semicolon.

Column: 37
Error code: W033
```

Commits:

	Summary
-		Convert $.setVisible to $.toggle.
+		Convert $.setVisible to $.toggle.

Diff:

Revision 2 (+14 -6)

Show changes

	djblets/static/djblets/js/jquery.gravy.backboneUtils.js
	djblets/static/djblets/js/jquery.gravy.util.js
	djblets/static/djblets/js/forms/views/conditionSetView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (d63745b)