Convert $.setVisible to $.toggle.

Review Request #12975 — Created April 21, 2023 and submitted

Information

Djblets
release-4.x

Reviewers

When we first wrote Djblets's JS codebase, jQuery forced you to either
use .show() or .hide(), and didn't have a way to easily show based
on a bool, so we wrote our own. Way back in jQuery 1.3, they added this,
but we never noticed. This change updates our codebase to use
$.toggle() instead.

Ran js-tests.

Summary ID
Convert $.setVisible to $.toggle.
When we first wrote Djblets's JS codebase, jQuery forced you to either use `.show()` or `.hide()`, and didn't have a way to easily show based on a bool, so we wrote our own. Way back in jQuery 1.3, they added this, but we never noticed. This change updates our codebase to use `$.toggle()` instead. Testing Done: Ran js-tests.
4989bf44083a42e4b525547745c52e6d99d0d8b8
Description From Last Updated

Missing semicolon. Column: 37 Error code: W033

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.x (d63745b)