Summary:

Get rid of old inline editor utility methods in TextEditorView.

Review Request #12970 — Created April 21, 2023 and submitted April 25, 2023, 11:42 a.m.

Information
Owner:	david
Repository:	Review Board
Branch:	release-6.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

Now that everything that used the old $.ui.inlineEditor implementation
has been converted to the new InlineEditorView, there are a couple
utility methods inside TextEditorView that are obsolete. This change
deletes that code.

Testing Done

Ran js-tests.

Commits

Summary
	Get rid of old inline editor utility methods in TextEditorView.

Screenshots

Issues

Description	From	Last Updated
Should this go through a deprecation cycle? If an extension sets up their own inline editor, we'll break them.	chipx86	April 21, 2023, 4:18 p.m.

flake8 passed.

JSHint passed.

Show all issues

Should this go through a deprecation cycle? If an extension sets up their own inline editor, we'll break them.

david April 21, 2023, 4:16 p.m.

I don't know if that's actually necessary here. This wasn't used even for the vast majority of our own inline editors. I'd put money down that if anybody was using inline editor they were getting it for free via the review request fields.

chipx86 April 21, 2023, 4:16 p.m.
```
Okay, just wanted to check on that.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (daffcf2)