Get rid of old inline editor utility methods in TextEditorView.

 






 

 


  Review Request #12970
  —
  Created April 21, 2023 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Now that everything that used the old $.ui.inlineEditor implementation

has been converted to the new InlineEditorView, there are a couple

utility methods inside TextEditorView that are obsolete. This change

deletes that code.

 








  


 
 

  
Ran js-tests.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Get rid of old inline editor utility methods in TextEditorView.
      
Now that everything that used the old `$.ui.inlineEditor` implementation
has been converted to the new `InlineEditorView`, there are a couple
utility methods inside `TextEditorView` that are obsolete. This change
deletes that code.

Testing Done:
Ran js-tests.

     


    		
    fd3717df7f6ff2e006d0b741b7eb5570edc9a8c1

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Should this go through a deprecation cycle? If an extension sets up their own inline editor, we'll break them.

      		
      
       chipx86chipx86
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Should this go through a deprecation cycle? If an extension sets up their own inline editor, we'll break them.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I don't know if that's actually necessary here. This wasn't used even for the vast majority of our own inline editors. I'd put money down that if anybody was using inline editor they were getting it for free via the review request fields.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Okay, just wanted to check on that.
      
 
      

      3. 


 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-6.x (daffcf2)





 


 










  

 









     

    

   

  

  

   
   Loading...