flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js (Diff revision 1) Show all issues
Review Request #12969 — Created April 21, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
This change updates the last use of the old
$.ui.inlineEditor
to use
our new(er)InlineEditorView
.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+24 -18) |
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js (Diff revision 2) |
---|
We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and set it. Makes it more readable and avoids unnecessary accesses.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+24 -18) |