Update APITokensView to use InlineEditorView for the notes field.

Review Request #12969 — Created April 21, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

This change updates the last use of the old $.ui.inlineEditor to use
our new(er) InlineEditorView.

  • Ran js-tests.
  • Edited the notes for an API token.
Summary ID
Update APITokensView to use InlineEditorView for the notes field.
This change updates the last use of the old `$.ui.inlineEditor` to use our new(er) `InlineEditorView`. Testing Done: - Ran js-tests. - Edited the notes for an API token.
ed27ee1bf0b05b67e8668dbb09304ca3bf6e11f4
Description From Last Updated

Missing semicolon. Column: 62 Error code: W033

reviewbotreviewbot

We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and …

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
chipx86
  1. Ship It!

  2. 
      
chipx86
  1. 
      
  2. Show all issues

    We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and set it. Makes it more readable and avoids unnecessary accesses.

    1. We don't even need to store it on the class in this case.

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (3e0d1b8)