Summary

Update APITokensView to use InlineEditorView for the notes field.

Review Request #12969 — Created April 21, 2023 and submitted April 25, 2023, 11:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the last use of the old $.ui.inlineEditor to use
our new(er) InlineEditorView.

Testing Done


Ran js-tests.
Edited the notes for an API token.

Commits

Summary	ID
Update APITokensView to use InlineEditorView for the notes field. This change updates the last use of the old `$.ui.inlineEditor` to use our new(er) `InlineEditorView`. Testing Done: - Ran js-tests. - Edited the notes for an API token.	ed27ee1bf0b05b67e8668dbb09304ca3bf6e11f4

Issues

Description	From	Last Updated
Missing semicolon. Column: 62 Error code: W033	reviewbot	April 21, 2023, 10:09 a.m.
We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and …	chipx86	April 21, 2023, 4:30 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js (Diff revision 1)
Show all issues
```
Missing semicolon.

Column: 62
Error code: W033
```

Commits:

	Summary	ID
	Update APITokensView to use InlineEditorView for the notes field. This change updates the last use of the old `$.ui.inlineEditor` to use our new(er) `InlineEditorView`. Testing Done: - Ran js-tests. - Edited the notes for an API token.	5ccc48d3c8b32963e4a4a44262e5732ef58f57c3
	Update APITokensView to use InlineEditorView for the notes field. This change updates the last use of the old `$.ui.inlineEditor` to use our new(er) `InlineEditorView`. Testing Done: - Ran js-tests. - Edited the notes for an API token.	fa1e5f9ba7a0fea0283688380b93f08f90ca81a8

Diff:

Revision 2 (+24 -18)

Show changes

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

```
Ship It!
```

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js (Diff revision 2)

Show all issues

We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and set it. Makes it more readable and avoids unnecessary accesses.

david April 21, 2023, 4:31 p.m.

We don't even need to store it on the class in this case.

Commits:

	Summary	ID
	Update APITokensView to use InlineEditorView for the notes field. This change updates the last use of the old `$.ui.inlineEditor` to use our new(er) `InlineEditorView`. Testing Done: - Ran js-tests. - Edited the notes for an API token.	fa1e5f9ba7a0fea0283688380b93f08f90ca81a8
	Update APITokensView to use InlineEditorView for the notes field. This change updates the last use of the old `$.ui.inlineEditor` to use our new(er) `InlineEditorView`. Testing Done: - Ran js-tests. - Edited the notes for an API token.	ed27ee1bf0b05b67e8668dbb09304ca3bf6e11f4

Diff:

Revision 3 (+24 -18)

Show changes

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (3e0d1b8)