flake8
passed.
JSHint
passed.
Review Request #12968 — Created April 21, 2023 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
This is another change in the process of coverting from our old
$.ui.inlineEditor
to the new(er)InlineEditorView
. This updates the
screenshot thumbnail caption editor, which in practice will never
actually be used anymore.
Ran js-tests.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and … |
|
reviewboard/static/rb/js/views/screenshotThumbnailView.es6.js (Diff revision 1) |
---|
We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and set it. Makes it more readable and avoids unnecessary accesses.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+82 -62) |