This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-6.x (551cf88)

Summary

Update ScreenshotThumbnailView to use InlineEditorView.

Review Request #12968 — Created April 21, 2023 and submitted 2 years ago

Information

Owner

david*

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

This is another change in the process of coverting from our old
$.ui.inlineEditor to the new(er) InlineEditorView. This updates the
screenshot thumbnail caption editor, which in practice will never
actually be used anymore.

Testing Done

Ran js-tests.

Commits

Summary	ID
Update ScreenshotThumbnailView to use InlineEditorView. This is another change in the process of coverting from our old `$.ui.inlineEditor` to the new(er) `InlineEditorView`. This updates the screenshot thumbnail caption editor, which in practice will never actually be used anymore. Testing Done: Ran js-tests.	6f9cc0c0de00f609ba7102ad8447c9c6552a9826

Issues

Description	From	Last Updated
We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and …	chipx86	2 years ago
There are no open issues

flake8 passed.

JSHint passed.

```
Ship It!
```

reviewboard/static/rb/js/views/screenshotThumbnailView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and set it. Makes it more readable and avoids unnecessary accesses.

Commits:

	Summary	ID
	Update ScreenshotThumbnailView to use InlineEditorView. This is another change in the process of coverting from our old `$.ui.inlineEditor` to the new(er) `InlineEditorView`. This updates the screenshot thumbnail caption editor, which in practice will never actually be used anymore. Testing Done: Ran js-tests.	14f4274124936a78736501619ad025e465b20169
	Update ScreenshotThumbnailView to use InlineEditorView. This is another change in the process of coverting from our old `$.ui.inlineEditor` to the new(er) `InlineEditorView`. This updates the screenshot thumbnail caption editor, which in practice will never actually be used anymore. Testing Done: Ran js-tests.	6f9cc0c0de00f609ba7102ad8447c9c6552a9826

Diff:

Revision 2 (+82 -62)

Show changes

	reviewboard/static/rb/js/views/screenshotThumbnailView.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js
	reviewboard/static/rb/js/views/tests/screenshotThumbnailViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (551cf88)