Update to Jasmine 3.8.0

 






 

 


  Review Request #12967
  —
  Created April 21, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
I want to use Spy.calls.thisFor() in an upcoming change, but that

wasn't introduced until Jasmine 3.8.0. This change updates us to use

that.


I spent a while trying to get it so I could import Jasmine entirely from

node_modules the way  we do for most of our 3rdparty libs, but I

haven't been successful on that yet, so this just updates the bundled

copy.


This also exposed a case where we weren't properly using

await expectAsync, which meant that some expect calls were happening

after the test case completed.

 








  


 
 

  
Ran js-tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Update to Jasmine 3.8.0
     
I want to use `Spy.calls.thisFor()` in an upcoming change, but that
wasn't introduced until Jasmine 3.8.0. This change updates us to use
that.

I spent a while trying to get it so I could import Jasmine entirely from
`node_modules` the way  we do for most of our 3rdparty libs, but I
haven't been successful on that yet, so this just updates the bundled
copy.

This also exposed a case where we weren't properly using
`await expectAsync`, which meant that some expect calls were happening
after the test case completed.

Testing Done:
Ran js-tests.

    

   
  		
  4b0ead411d8ba77dbf19e0d6e44eefcec88dfc3f
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      package-lock.json
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/dependencies.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/package.json
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/lib/js/js-test-libs/jasmine-3.5.0.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/lib/js/js-test-libs/jasmine-boot-3.5.0.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/lib/js/js-test-libs/jasmine-html-3.5.0.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...