Update to Jasmine 3.8.0

Review Request #12967 — Created April 21, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

I want to use Spy.calls.thisFor() in an upcoming change, but that
wasn't introduced until Jasmine 3.8.0. This change updates us to use
that.

I spent a while trying to get it so I could import Jasmine entirely from
node_modules the way we do for most of our 3rdparty libs, but I
haven't been successful on that yet, so this just updates the bundled
copy.

This also exposed a case where we weren't properly using
await expectAsync, which meant that some expect calls were happening
after the test case completed.

Ran js-tests.

Summary ID
Update to Jasmine 3.8.0
I want to use `Spy.calls.thisFor()` in an upcoming change, but that wasn't introduced until Jasmine 3.8.0. This change updates us to use that. I spent a while trying to get it so I could import Jasmine entirely from `node_modules` the way we do for most of our 3rdparty libs, but I haven't been successful on that yet, so this just updates the bundled copy. This also exposed a case where we weren't properly using `await expectAsync`, which meant that some expect calls were happening after the test case completed. Testing Done: Ran js-tests.
4b0ead411d8ba77dbf19e0d6e44eefcec88dfc3f
Description From Last Updated

Expected '===' and instead saw '=='. Column: 53 Error code: W116

reviewbotreviewbot

'props' is already defined. Column: 9 Error code: W004

reviewbotreviewbot

'copy' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

'arrayProps' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

'expectSettledPromiseFilter' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

'indent' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

Inner functions should be listed at the top of the outer function. Column: 3 Error code: W026

reviewbotreviewbot

'matchError' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

'getExpectedFromArgs' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

It's not necessary to initialize 'actualRoot' to 'undefined'. Column: 7 Error code: W080

reviewbotreviewbot

It's not necessary to initialize 'expectedRoot' to 'undefined'. Column: 7 Error code: W080

reviewbotreviewbot

Inner functions should be listed at the top of the outer function. Column: 5 Error code: W026

reviewbotreviewbot

'defaultFormatter' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'wrapPrettyPrinted' was used before it was defined. Column: 14 Error code: W003

reviewbotreviewbot

'dereferencePath' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

Inner functions should be listed at the top of the outer function. Column: 3 Error code: W026

reviewbotreviewbot

Expected '!==' and instead saw '!='. Column: 15 Error code: W116

reviewbotreviewbot

Expected '!==' and instead saw '!='. Column: 25 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 60 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 73 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 22 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 26 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 28 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 33 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 37 Error code: W116

reviewbotreviewbot

'objectKeysAreDifferentFormatter' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

'constructorsAreDifferentFormatter' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

'actualArrayIsLongerFormatter' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

'formatKeyValuePairs' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot

'isDiffBuilder' was used before it was defined. Column: 12 Error code: W003

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (d255a6c)