Summary

Update to Jasmine 3.8.0

Review Request #12967 — Created April 21, 2023 and submitted April 21, 2023, 4:09 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

I want to use Spy.calls.thisFor() in an upcoming change, but that

wasn't introduced until Jasmine 3.8.0. This change updates us to use

that.
I spent a while trying to get it so I could import Jasmine entirely from

node_modules the way  we do for most of our 3rdparty libs, but I

haven't been successful on that yet, so this just updates the bundled

copy.
This also exposed a case where we weren't properly using

await expectAsync, which meant that some expect calls were happening

after the test case completed.

Testing Done

Ran js-tests.

Commits

Summary	ID
Update to Jasmine 3.8.0 I want to use `Spy.calls.thisFor()` in an upcoming change, but that wasn't introduced until Jasmine 3.8.0. This change updates us to use that. I spent a while trying to get it so I could import Jasmine entirely from `node_modules` the way we do for most of our 3rdparty libs, but I haven't been successful on that yet, so this just updates the bundled copy. This also exposed a case where we weren't properly using `await expectAsync`, which meant that some expect calls were happening after the test case completed. Testing Done: Ran js-tests.	4b0ead411d8ba77dbf19e0d6e44eefcec88dfc3f

Summary

Update to Jasmine 3.8.0

I want to use `Spy.calls.thisFor()` in an upcoming change, but that wasn't introduced until Jasmine 3.8.0. This change updates us to use that. I spent a while trying to get it so I could import Jasmine entirely from `node_modules` the way we do for most of our 3rdparty libs, but I haven't been successful on that yet, so this just updates the bundled copy. This also exposed a case where we weren't properly using `await expectAsync`, which meant that some expect calls were happening after the test case completed. Testing Done: Ran js-tests.

4b0ead411d8ba77dbf19e0d6e44eefcec88dfc3f

Issues

Description	From	Last Updated
Expected '===' and instead saw '=='. Column: 53 Error code: W116	reviewbot	April 21, 2023, 9:36 a.m.
'props' is already defined. Column: 9 Error code: W004	reviewbot	April 21, 2023, 9:36 a.m.
'copy' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
'arrayProps' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
'expectSettledPromiseFilter' was used before it was defined. Column: 7 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
'indent' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
Inner functions should be listed at the top of the outer function. Column: 3 Error code: W026	reviewbot	April 21, 2023, 9:36 a.m.
'matchError' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
'getExpectedFromArgs' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
It's not necessary to initialize 'actualRoot' to 'undefined'. Column: 7 Error code: W080	reviewbot	April 21, 2023, 9:36 a.m.
It's not necessary to initialize 'expectedRoot' to 'undefined'. Column: 7 Error code: W080	reviewbot	April 21, 2023, 9:36 a.m.
Inner functions should be listed at the top of the outer function. Column: 5 Error code: W026	reviewbot	April 21, 2023, 9:36 a.m.
'defaultFormatter' was used before it was defined. Column: 14 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
'wrapPrettyPrinted' was used before it was defined. Column: 14 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
'dereferencePath' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:36 a.m.
Inner functions should be listed at the top of the outer function. Column: 3 Error code: W026	reviewbot	April 21, 2023, 9:36 a.m.
Expected '!==' and instead saw '!='. Column: 15 Error code: W116	reviewbot	April 21, 2023, 9:36 a.m.
Expected '!==' and instead saw '!='. Column: 25 Error code: W116	reviewbot	April 21, 2023, 9:36 a.m.
Expected '===' and instead saw '=='. Column: 60 Error code: W116	reviewbot	April 21, 2023, 9:36 a.m.
Expected '===' and instead saw '=='. Column: 73 Error code: W116	reviewbot	April 21, 2023, 9:36 a.m.
Expected '===' and instead saw '=='. Column: 22 Error code: W116	reviewbot	April 21, 2023, 9:36 a.m.
Expected '===' and instead saw '=='. Column: 26 Error code: W116	reviewbot	April 21, 2023, 9:36 a.m.
Expected '===' and instead saw '=='. Column: 28 Error code: W116	reviewbot	April 21, 2023, 9:37 a.m.
Expected '===' and instead saw '=='. Column: 33 Error code: W116	reviewbot	April 21, 2023, 9:37 a.m.
Expected '===' and instead saw '=='. Column: 37 Error code: W116	reviewbot	April 21, 2023, 9:37 a.m.
'objectKeysAreDifferentFormatter' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:37 a.m.
'constructorsAreDifferentFormatter' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:37 a.m.
'actualArrayIsLongerFormatter' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:37 a.m.
'formatKeyValuePairs' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:37 a.m.
'isDiffBuilder' was used before it was defined. Column: 12 Error code: W003	reviewbot	April 21, 2023, 9:37 a.m.

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 43 failures.
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 53
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'props' is already defined.

Column: 9
Error code: W004
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'copy' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'arrayProps' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'expectSettledPromiseFilter' was used before it was defined.

Column: 7
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'indent' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Inner functions should be listed at the top of the outer function.

Column: 3
Error code: W026
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'matchError' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'getExpectedFromArgs' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
It's not necessary to initialize 'actualRoot' to 'undefined'.

Column: 7
Error code: W080
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
It's not necessary to initialize 'expectedRoot' to 'undefined'.

Column: 7
Error code: W080
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Inner functions should be listed at the top of the outer function.

Column: 5
Error code: W026
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'defaultFormatter' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'wrapPrettyPrinted' was used before it was defined.

Column: 14
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'dereferencePath' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Inner functions should be listed at the top of the outer function.

Column: 3
Error code: W026
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '!==' and instead saw '!='.

Column: 15
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '!==' and instead saw '!='.

Column: 25
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 60
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 73
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 22
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 26
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 28
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 33
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Expected '===' and instead saw '=='.

Column: 37
Error code: W116
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'objectKeysAreDifferentFormatter' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'constructorsAreDifferentFormatter' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'actualArrayIsLongerFormatter' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'formatKeyValuePairs' was used before it was defined.

Column: 12
Error code: W003
```
reviewboard/static/lib/js/js-test-libs/jasmine-3.8.0.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'isDiffBuilder' was used before it was defined.

Column: 12
Error code: W003
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (d255a6c)