Update to Jasmine 3.8.0
Review Request #12967 — Created April 21, 2023 and submitted
I want to use
Spy.calls.thisFor()
in an upcoming change, but that
wasn't introduced until Jasmine 3.8.0. This change updates us to use
that.I spent a while trying to get it so I could import Jasmine entirely from
node_modules
the way we do for most of our 3rdparty libs, but I
haven't been successful on that yet, so this just updates the bundled
copy.This also exposed a case where we weren't properly using
await expectAsync
, which meant that some expect calls were happening
after the test case completed.
Ran js-tests.
Summary | ID |
---|---|
4b0ead411d8ba77dbf19e0d6e44eefcec88dfc3f |
Description | From | Last Updated | ||
---|---|---|---|---|
Expected '===' and instead saw '=='. Column: 53 Error code: W116 |
reviewbot | |||
'props' is already defined. Column: 9 Error code: W004 |
reviewbot | |||
'copy' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
'arrayProps' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
'expectSettledPromiseFilter' was used before it was defined. Column: 7 Error code: W003 |
reviewbot | |||
'indent' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
Inner functions should be listed at the top of the outer function. Column: 3 Error code: W026 |
reviewbot | |||
'matchError' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
'getExpectedFromArgs' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
It's not necessary to initialize 'actualRoot' to 'undefined'. Column: 7 Error code: W080 |
reviewbot | |||
It's not necessary to initialize 'expectedRoot' to 'undefined'. Column: 7 Error code: W080 |
reviewbot | |||
Inner functions should be listed at the top of the outer function. Column: 5 Error code: W026 |
reviewbot | |||
'defaultFormatter' was used before it was defined. Column: 14 Error code: W003 |
reviewbot | |||
'wrapPrettyPrinted' was used before it was defined. Column: 14 Error code: W003 |
reviewbot | |||
'dereferencePath' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
Inner functions should be listed at the top of the outer function. Column: 3 Error code: W026 |
reviewbot | |||
Expected '!==' and instead saw '!='. Column: 15 Error code: W116 |
reviewbot | |||
Expected '!==' and instead saw '!='. Column: 25 Error code: W116 |
reviewbot | |||
Expected '===' and instead saw '=='. Column: 60 Error code: W116 |
reviewbot | |||
Expected '===' and instead saw '=='. Column: 73 Error code: W116 |
reviewbot | |||
Expected '===' and instead saw '=='. Column: 22 Error code: W116 |
reviewbot | |||
Expected '===' and instead saw '=='. Column: 26 Error code: W116 |
reviewbot | |||
Expected '===' and instead saw '=='. Column: 28 Error code: W116 |
reviewbot | |||
Expected '===' and instead saw '=='. Column: 33 Error code: W116 |
reviewbot | |||
Expected '===' and instead saw '=='. Column: 37 Error code: W116 |
reviewbot | |||
'objectKeysAreDifferentFormatter' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
'constructorsAreDifferentFormatter' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
'actualArrayIsLongerFormatter' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
'formatKeyValuePairs' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
'isDiffBuilder' was used before it was defined. Column: 12 Error code: W003 |
reviewbot | |||
There are no open issues |