This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-6.x (fb8c5f2)

Summary

Convert the ReviewReplyEditorView to use InlineEditorView.

Review Request #12964 — Created April 20, 2023 and submitted 2 years ago — Latest diff uploaded 2 years, 1 month ago

Information

Owner

david*

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

We've had a long-term goal of replacing all our uses of the old
$.inlineEditor with the new InlineEditorView. This change updates
the review reply for that.

Testing Done


Verified that creating new reply comments and editing existing reply

  comments worked correctly, building the editor with the correct

  content and saving/cancelling as expected.
Ran js-tests.

Diff Revision 2 (Latest)

orig

Commits

First	Last	Summary	ID	Author
		Convert the ReviewReplyEditorView to use InlineEditorView. We've had a long-term goal of replacing all our uses of the old `$.inlineEditor` with the new `InlineEditorView`. This change updates the review reply for that. Testing Done: - Verified that creating new reply comments and editing existing reply comments worked correctly, building the editor with the correct content and saving/cancelling as expected. - Ran js-tests.	857443a09373a913d0d60f2d6140708a0b84a516	David Trowbridge

Files

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js