Convert the ReviewReplyEditorView to use InlineEditorView.

Review Request #12964 — Created April 20, 2023 and submitted

Information

Review Board
release-6.x

Reviewers

We've had a long-term goal of replacing all our uses of the old
$.inlineEditor with the new InlineEditorView. This change updates
the review reply for that.

  • Verified that creating new reply comments and editing existing reply
    comments worked correctly, building the editor with the correct
    content and saving/cancelling as expected.
  • Ran js-tests.
Summary ID
Convert the ReviewReplyEditorView to use InlineEditorView.
We've had a long-term goal of replacing all our uses of the old `$.inlineEditor` with the new `InlineEditorView`. This change updates the review reply for that. Testing Done: - Verified that creating new reply comments and editing existing reply comments worked correctly, building the editor with the correct content and saving/cancelling as expected. - Ran js-tests.
857443a09373a913d0d60f2d6140708a0b84a516
Description From Last Updated

Let's keep the elements grouped together separately from the view.

chipx86chipx86

We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and …

chipx86chipx86
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Let's keep the elements grouped together separately from the view.

  3. We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and set it. Makes it more readable and avoids unnecessary accesses.

  4. 
      
david
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (fb8c5f2)
Loading...