Summary:

Convert the ReviewReplyEditorView to use InlineEditorView.

Review Request #12964 — Created April 20, 2023 and submitted April 25, 2023, 11:42 a.m.

Information
Owner:	david
Repository:	Review Board
Branch:	release-6.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

We've had a long-term goal of replacing all our uses of the old
$.inlineEditor with the new InlineEditorView. This change updates
the review reply for that.

Testing Done


Verified that creating new reply comments and editing existing reply

  comments worked correctly, building the editor with the correct

  content and saving/cancelling as expected.
Ran js-tests.

Commits

Summary
	Convert the ReviewReplyEditorView to use InlineEditorView.

Screenshots

Issues

Description	From	Last Updated
Let's keep the elements grouped together separately from the view.	chipx86	April 21, 2023, 4:16 p.m.
We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and …	chipx86	April 21, 2023, 4:17 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js (Diff revision 1)
Show all issues
```
Let's keep the elements grouped together separately from the view.
```

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js (Diff revision 1)

Show all issues

We do these repeated property accesses over and over. Let's pull these out into a local variable, use it, and set it. Makes it more readable and avoids unnecessary accesses.

Commits:

	Summary
-		Convert the ReviewReplyEditorView to use InlineEditorView.
+		Convert the ReviewReplyEditorView to use InlineEditorView.

Diff:

Revision 2 (+90 -86)

Show changes

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (fb8c5f2)