Convert the ReviewReplyEditorView to use InlineEditorView.

 






 

 


  Review Request #12964
  —
  Created April 20, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
We've had a long-term goal of replacing all our uses of the old

$.inlineEditor with the new InlineEditorView. This change updates

the review reply for that.

 








  


 
 

  
    

  • Verified that creating new reply comments and editing existing reply
    
  comments worked correctly, building the editor with the correct
    
  content and saving/cancelling as expected.
    • 

  • Ran js-tests.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert the ReviewReplyEditorView to use InlineEditorView.
     
We've had a long-term goal of replacing all our uses of the old
`$.inlineEditor` with the new `InlineEditorView`. This change updates
the review reply for that.

Testing Done:
- Verified that creating new reply comments and editing existing reply
  comments worked correctly, building the editor with the correct
  content and saving/cancelling as expected.
- Ran js-tests.

    

   
  		
  2832f783249153d2916bccda0d22a048639c93e1
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyEditorView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...