Summary

Fix API issues creating comments on draft file attachments.

Review Request #12962 — Created April 19, 2023 and submitted April 21, 2023, 4:12 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change fixes up a couple issues with the API making comments on
not-yet-published file attachments. The main problem here is that draft
attachments are related only to the draft and not yet to the review
request. This change fixes up the questios for both get_queryset and
create to handle this.

Testing Done


Ran unit tests.
Added some comments to file attachments which were not yet published.

Commits

Summary	ID
Fix API issues creating comments on draft file attachments. This change fixes up a couple issues with the API making comments on not-yet-published file attachments. The main problem here is that draft attachments are related only to the draft and not yet to the review request. This change fixes up the questios for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to file attachments which were not yet published.	8908d2b022c1a6455805c8f60cd7a9244ff8d4df

Summary

Fix API issues creating comments on draft file attachments.

This change fixes up a couple issues with the API making comments on not-yet-published file attachments. The main problem here is that draft attachments are related only to the draft and not yet to the review request. This change fixes up the questios for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to file attachments which were not yet published.

8908d2b022c1a6455805c8f60cd7a9244ff8d4df

Issues

Description	From	Last Updated
Could add a new test for POSTing comments to a draft file attachment.	maubin	April 20, 2023, 10:34 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Could add a new test for POSTing comments to a draft file attachment.

Change Summary:

Add a unit test.

Commits:

	Summary	ID
	Fix API issues creating comments on draft file attachments. This change fixes up a couple issues with the API making comments on not-yet-published file attachments. The main problem here is that draft attachments are related only to the draft and not yet to the review request. This change fixes up the questios for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to file attachments which were not yet published.	3844ba320d739ab0c068a46f0d6ec732445338ea
	Fix API issues creating comments on draft file attachments. This change fixes up a couple issues with the API making comments on not-yet-published file attachments. The main problem here is that draft attachments are related only to the draft and not yet to the review request. This change fixes up the questios for both `get_queryset` and `create` to handle this. Testing Done: - Ran unit tests. - Added some comments to file attachments which were not yet published.	8908d2b022c1a6455805c8f60cd7a9244ff8d4df

Diff:

Revision 2 (+200 -30)

Show changes

	reviewboard/webapi/resources/base_file_attachment_comment.py
	reviewboard/webapi/resources/review_file_attachment_comment.py
	reviewboard/webapi/tests/test_file_attachment_comment.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (80cf91b)