Plumb through redirect URL on the "Log in with SAML SSO" button.

Review Request #12957 — Created April 17, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

When SAML autologin is enabled, we were correctly passing through the
redirect URL, but that was not included on the link for the "Log in with
SAML SSO" button on the login page. This was annoying to users when they
tried to open links to specific pages and they'd end up on the dashboard
instead.

  • Ran unit tests.
  • Opened /r/1/ on my test server and saw that I was redirected to the
    login page. Clicked the SAML login button, went through that flow, and
    saw that I was correctly redirected back to /r/1/ instead of to
    /dashboard/
Summary ID
Plumb through redirect URL on the "Log in with SAML SSO" button.
When SAML autologin is enabled, we were correctly passing through the redirect URL, but that was not included on the link for the "Log in with SAML SSO" button on the login page. This was annoying to users when they tried to open links to specific pages and they'd end up on the dashboard instead. Testing Done: - Ran unit tests. - Opened /r/1/ on my test server and saw that I was redirected to the login page. Clicked the SAML login button, went through that flow, and saw that I was correctly redirected back to /r/1/ instead of to /dashboard/
2ac5b727b98c32a57fb8920cfe26fdeb09014c58
Description From Last Updated

Is there any chance that the login_url would ever contain a ? in it?

chipx86chipx86
chipx86
  1. 
      
  2. Is there any chance that the login_url would ever contain a ? in it?

    1. No, it shouldn't. This maps to a view handled by the SSO backend to trigger the login flow, which shouldn't require any query parameters.

  3. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (f244760)
Loading...