Summary:

Plumb through redirect URL on the "Log in with SAML SSO" button.

Review Request #12957 — Created April 17, 2023 and submitted April 20, 2023, 9:26 a.m.

Information
Owner:	david
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

When SAML autologin is enabled, we were correctly passing through the
redirect URL, but that was not included on the link for the "Log in with
SAML SSO" button on the login page. This was annoying to users when they
tried to open links to specific pages and they'd end up on the dashboard
instead.

Testing Done


Ran unit tests.
Opened /r/1/ on my test server and saw that I was redirected to the

  login page. Clicked the SAML login button, went through that flow, and

  saw that I was correctly redirected back to /r/1/ instead of to

  /dashboard/

Commits

Summary
	Plumb through redirect URL on the "Log in with SAML SSO" button.

Screenshots

Issues

Description	From	Last Updated
Is there any chance that the login_url would ever contain a ? in it?	chipx86	April 18, 2023, 3:56 p.m.

flake8 passed.

JSHint passed.

reviewboard/templates/accounts/login.html (Diff revision 1)

Show all issues

Is there any chance that the login_url would ever contain a ? in it?

david April 18, 2023, 3:56 p.m.

No, it shouldn't. This maps to a view handled by the SSO backend to trigger the login flow, which shouldn't require any query parameters.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (f244760)