Prevent visual jumps when editing the change description.

Review Request #12953 — Created April 13, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

The line-height of the label for the change description field in the
unified banner wasn't enforcing a match between the text and the edit
icon, which meant that the UI would jump a few pixels when entering edit
mode (which hides the icon). Setting this explicitly makes it so things
don't reflow when that icon appears or disappears.

Entered/exited edit mode for the change description and saw that
everything stayed in one place.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Prevent visual jumps when editing the change description.
The line-height of the label for the change description field in the unified banner wasn't enforcing a match between the text and the edit icon, which meant that the UI would jump a few pixels when entering edit mode (which hides the icon). Setting this explicitly makes it so things don't reflow when that icon appears or disappears. Testing Done: Entered/exited edit mode for the change description and saw that everything stayed in one place.
f09ded8dcddc93e97779b9f6809e685be6e4ba5f David Trowbridge
reviewboard/static/rb/css/defs.less
reviewboard/static/rb/css/assets/icons.less
reviewboard/static/rb/css/ui/banners.less
Loading...